Add missing browser tests for "nothing selected by default" behavior
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Missing browser tests:

The existing browser tests currently click on the left radio buttons, but do this blindly without checking anything before. Simple fix: Add an assertion to check if nothing was selected before.
A new browser test for the non-JS behavior would be great.

Details

	Subject	Repo	Branch	Lines +/-
	Browser tests: Check if no side is selected by default	mediawiki/extensions/TwoColConflict	master	+8 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		WMDE-Fisch	T245410 Neither column of a conflict should be selected by default
		Resolved		WMDE-Fisch	T246646 Add missing browser tests for "nothing selected by default" behavior

Event Timeline

thiemowmde created this task.Mar 2 2020, 10:54 AM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptMar 2 2020, 10:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

thiemowmde added subtasks: T245410: Neither column of a conflict should be selected by default, T245505: Non-JS error handling when a conflict is submitted with no column selected.Mar 2 2020, 10:57 AM

Change 576010 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Browser tests: Check if no side is selected by default

https://gerrit.wikimedia.org/r/576010

gerritbot added a project: Patch-For-Review.Mar 2 2020, 11:49 AM

thiemowmde moved this task from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.Mar 3 2020, 1:06 PM

awight moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-02-19 board.Mar 4 2020, 10:48 AM

awight added a project: WMDE-QWERTY-Sprint-2020-03-04.

awight moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-03-04 board.

awight set the point value for this task to 0.

awight changed the status of subtask T245505: Non-JS error handling when a conflict is submitted with no column selected from Open to Stalled.Mar 4 2020, 11:02 AM

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-03-04 board.Mar 4 2020, 12:24 PM

Change 576010 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Browser tests: Check if no side is selected by default

https://gerrit.wikimedia.org/r/576010

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 4 2020, 1:00 PM