Fix tests that fail with partial blocks enabled
Closed, ResolvedPublic
Actions

Description

In order to remove $wgEnablePartialBlocks, the following tests need to be fixed so that they pass with partial blocks enabled:

SpecialBlockTest::testGetFormFields
SpecialBlockTest::testProcessForm
SpecialBlockTest::testProcessFormExisting
BlockListPagerTest::testFormatValue

Details

	Subject	Repo	Branch	Lines +/-
	Ensure all tests pass with partial blocks enabled	mediawiki/core	master	+9 -25

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Mar 12 2020	Tchanders	T242912 Remove $wgEnablePartialBlocks feature flag
		Resolved		Tchanders	T246685 Fix tests that fail with partial blocks enabled

Event Timeline

Tchanders created this task.Mar 2 2020, 4:59 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 2 2020, 4:59 PM

Tchanders moved this task from Untriaged to The Letter Song on the Anti-Harassment board.Mar 2 2020, 5:05 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

Change 576110 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] Ensure all tests pass with partial blocks enabled

https://gerrit.wikimedia.org/r/576110

gerritbot added a project: Patch-For-Review.Mar 2 2020, 6:33 PM

Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Mar 2 2020, 6:35 PM

Change 576110 merged by jenkins-bot:
[mediawiki/core@master] Ensure all tests pass with partial blocks enabled

https://gerrit.wikimedia.org/r/576110

Tchanders closed this task as Resolved.Mar 3 2020, 9:53 PM

Tchanders moved this task from Code Review 🔍 to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 3 2020, 10:00 PM

Jdforrester-WMF edited projects, added MW-1.35-notes (1.35.0-wmf.23; 2020-03-10); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 5 2020, 2:59 PM

JJMC89 edited projects, added MediaWiki-Blocks; removed MediaWiki-General.Apr 25 2020, 8:01 PM

JJMC89 moved this task from Backlog to Partial blocks on the MediaWiki-Blocks board.