Page MenuHomePhabricator

WikiPage::doDeleteArticleReal falls back to $wgUser
Closed, ResolvedPublic

Description

Current signature:

	public function doDeleteArticleReal(
		$reason, $suppress = false, $u1 = null, $u2 = null, &$error = '', User $deleter = null,
		$tags = [], $logsubtype = 'delete', $immediate = false
	) {

Since $u1 and $u2 are unused, it should be pretty easy to migrate the user towards the front, with the eventual signature

	public function doDeleteArticleReal(
		$reason, User $deleter, $suppress = false, $u2 = null, &$error = '', $u3 = null,
		$tags = [], $logsubtype = 'delete', $immediate = false
	) {

Event Timeline

Change 576192 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Update WikiPage::dodoDeleteArticleReal to move user earlier

https://gerrit.wikimedia.org/r/576192

Change 576192 merged by jenkins-bot:
[mediawiki/core@master] Update WikiPage::doDeleteArticleReal to move user earlier

https://gerrit.wikimedia.org/r/576192

DannyS712 triaged this task as Medium priority.Mar 19 2020, 4:03 PM