Page MenuHomePhabricator

bot creates |quote= parameters from google books url
Closed, ResolvedPublic

Description

diff

in that edit, the google books url is: https://books.google.com/books?id=0XcpAAAAYAAJ&pg=PA449&dq=%22the+last+days+of+papal+rome%2

I noticed this edit because the bot copied the rvalue from &dq= to |quote= including the malformed trailing percent-encoded quote mark which is rendered as :
|quote=the last days of papal rome� – I have seen this before but did not bother to report it

I wonder if creating |quote= from the google books url is a good idea. In this example, it is wholly inappropriate because the title of the book is The Last Days of Papal Rome, 1850-1870. Other cases where I found the replacement character in |quote= were equally inappropriate. In general, I oppose the use of |quote= in cs1|2 citation templates. If some text from a source is sufficiently important to a Wikipedia article, include that text quotation in the article and then cite it; don't hide it in the references section. But, if editors are going to quote something in a citation, they should use |quote= to do it and not hide the quotation in the template's url.

Event Timeline

The %2 looks like a gigo, you have seen %2 before? I can check for it easily. Preserving the Google quote string is, I think, preferable to deleting it. No opinion on the quote argument generally unless you have another idea for preserving the quote/keywords some other way.

I suspect that the %2 is a corruption of %22 the double quote character; support for that is shown in this edit where the %22 became %2.

If you must preserve the search terms, perhaps they can be put in an html comment prefixed with 'google books search string: ' or some-such; perhaps like this:
<!-- google books search string: '&dq=%22the+last+days+of+papal+rome%2' -->

But, I see no reason to keep the search string. If there is a page number that gets readers to the correct page, that is sufficient. If editors did not choose to quote from the source using |quote= or, better, <blockquote>...</blockquote>, a bot should not be second-guessing them and making up quotations that may or may not exist as quotable text in the source. For example, &dq=salafi+origins+Abduh from this citation at Salafi movement, does not exist (so says google) in the book. In this case, the search string appears to be a scattershot attempt to find some text in the book.

It will be disabled with the next batch.

The data is not lost it is saved on my computer should it need to be restored or used in some way in the future.

Harej added a subscriber: Cyberpower678.