Make common abstract class for PreliminaryCheckPager and ComparePager
Closed, ResolvedPublicMar 12 2020
Actions

Assigned To

Authored By

	Tchanders
	Mar 3 2020, 4:53 PM

Description

The main reason for this is to avoid duplication of getPagingQueries(), which is customised to work with the TokenManager.

We should do this ahead of making TimelinePager, which will also need the customised version of getPagingQueries.

Details

Due Date: Mar 12 2020, 4:00 AM

	Subject	Repo	Branch	Lines +/-
	Move common pagers implementation into base class	mediawiki/extensions/CheckUser	master	+101 -127

Customize query in gerrit

Event Timeline

Tchanders created this task.Mar 3 2020, 4:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2020, 4:53 PM

Niharika moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment board.Mar 4 2020, 10:06 PM

Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

dmaza moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Mar 5 2020, 9:52 PM

Change 577353 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Move common pagers implementation into base class

https://gerrit.wikimedia.org/r/577353

gerritbot added a project: Patch-For-Review.Mar 5 2020, 9:55 PM

dmaza claimed this task.Mar 6 2020, 4:19 AM

dmaza moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Mar 6 2020, 4:17 PM

Change 577353 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Move common pagers implementation into base class

https://gerrit.wikimedia.org/r/577353

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2020, 5:10 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 7 2020, 2:43 PM

ARamirez_WMF set Due Date to Mar 12 2020, 4:00 AM.Mar 13 2020, 6:14 PM

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

I have been testing CU with these changes for a few days. I haven't noticed any differences.

Tchanders closed this task as Resolved.Mar 16 2020, 12:31 PM

Make common abstract class for PreliminaryCheckPager and ComparePagerClosed, ResolvedPublicMar 12 2020Actions

Description

Details

Event Timeline

Make common abstract class for PreliminaryCheckPager and ComparePager
Closed, ResolvedPublicMar 12 2020
Actions