Page MenuHomePhabricator

Wrong font size for the reply box in DiscussionTools
Closed, ResolvedPublic

Description

The reply box in DiscussionTools uses different font size than the normal wikitext editor.

Actual:

Event Timeline

matmarex created this task.Mar 3 2020, 11:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 3 2020, 11:26 PM

Change 573385 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] mediawiki.editfont: Fix the OOUI font-size override

https://gerrit.wikimedia.org/r/573385

It should also have line-height: 1.5em, like the normal editor, otherwise fixing this bug makes it look kind of awful.

Change 576847 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Set line-height to match normal wikitext editor

https://gerrit.wikimedia.org/r/576847

Nice spot, BD.

Change 573385 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.editfont: Fix the OOUI font-size override

https://gerrit.wikimedia.org/r/573385

Change 576847 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] ReplyWidget: Set line-height to match normal wikitext editor

https://gerrit.wikimedia.org/r/576847

ppelberg closed this task as Resolved.Mar 18 2020, 3:32 PM