Page MenuHomePhabricator

Follow WMUI's font-family variable names in Vector skin
Open, LowPublic

Description

Inviting Readers Web team per JdlRobson's request.

Problem statement:
  • Less variable names
    • Don't follow the pattern of WMUI
    • Include implementation details: sans / serif
    • Lack semantic details: base (body) / heading
Solution:

3 renames:

  1. @font-family-sans -> @font-family-base -- Body content.
  2. @font-family-serif -> @font-family-heading -- Headings.
  3. @font-family-sans--fallback -> @font-family-heading--fallback -- Headings for languages Japanese, Hebrew, Korean (T73240,T65817,T65843,T65844,T65827)

Details

Related Gerrit Patches:

Event Timeline

Demian created this task.Wed, Mar 4, 1:56 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptWed, Mar 4, 1:56 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Demian updated the task description. (Show Details)Wed, Mar 4, 2:04 AM
Jdlrobson triaged this task as Low priority.Fri, Mar 6, 6:50 PM
Jdlrobson added a project: Readers-Web-Backlog.

This is not a priority for reading web at current time. Any change to the existing version of Vector is high risk for us right now, so will only be done on a must-do basis as part of building out desktop refresh. Right now typography is not within scope for that project.

Change 570638 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] Rename font-family variable names to follow WikimediaUI Base

https://gerrit.wikimedia.org/r/570638

This is not a priority for reading web at current time.

I'm aware of that, so I've made the change trivial and easy to evaluate. My target was 10 minutes / person necessary to judge it. In the for-profit sector we don't spend more on simple changes, but by now I know it's different here, so I'd like to make it easier.

This and the related documentation patches summarize the research that I've spent 2 weeks of free time on. Please appreciate the effort I've put into these patches to improve the documentation and save that 2 weeks for the next person who wants to understand the decisions behind these choices.

Any change to the existing version of Vector is high risk for us right now

The focus while implementing this change was to eliminate the risk, thus there's no functional change at all.
Three Less variables are renamed: a trivial change, that has no effect outside the project. In the project it affects 3 .less files, these aren't used anywhere else.

Right now typography is not within scope for that project.

There is no typography decision to be made here. That would be high risk, indeed.

Based on your feedback I've split this into 2 patches to make review easier:

  1. Adding the comments to the fonts. No code changes, obviously no risk. 577744
  2. Renaming @font-family-sans -> @font-family-base, @font-family-serif -> @font-family-heading, @font-family-sans--fallback -> @font-family-heading--fallback. 570638
Demian updated the task description. (Show Details)Sat, Mar 7, 10:14 AM
Restricted Application added a subscriber: revi. · View Herald TranscriptSat, Mar 7, 10:14 AM
Quiddity added a subscriber: Quiddity.

Projects-Cleanup (https://phabricator.wikimedia.org/project/profile/2829/) is just regarding cleanup for Phabricator tasks and projects.

Quiddity removed a subscriber: Quiddity.Sat, Mar 14, 9:32 PM