Language::dateFormat and ::userAdjust use $wgUser
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Mar 4 2020, 5:11 AM

Description

Too many callers and subclasses to add as a parameter

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove use of global $wgUser in Language::dateFormat and ::userAdjust	mediawiki/core	master	+9 -5

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T159283 Deprecate non-configuration globals
Resolved	MGChecker	T159299 Deprecate and remove $wgUser
Resolved	DannyS712	T267861 [GOAL] Emit deprecation warnings reading from $wgUser
Resolved	MGChecker	T243708 Mediawiki core needs uses of global $wgUser removed
Resolved	DannyS712	T242935 Deprecate core fallbacks to $wgUser
Resolved	DannyS712	T246862 Language::dateFormat and ::userAdjust use $wgUser

Change 576529 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add a user parameter to Language::dateFormat

DannyS712 renamed this task from Language::dateFormat uses $wgUser to Language::dateFormat and ::userAdjust use $wgUser.Mar 4 2020, 5:16 AM

DannyS712 updated the task description. (Show Details)

The usage without the second parameter (userAdjust) or first parameter (dateFormat) should be deprecated

Language::date/time/timeanddate should be deprecated in favour of Language::userDate/userTime/userTimeAndDate

Change 576529 merged by jenkins-bot:
[mediawiki/core@master] Remove use of global $wgUser in Language::dateFormat and ::userAdjust

DannyS712 closed this task as Resolved.Sep 15 2020, 1:39 AM