Page MenuHomePhabricator

Proposal after WikiPage/Article split
Open, Needs TriagePublic

Description

Context:

I found many unused methods, while I was working with https://phabricator.wikimedia.org/T239975

I recommend:

  • to research the usage of these methods and properties
  • to deprecate these methods and properties
  • to remove or change of visibility of these methods in 1.36

Goal:

  • to improve WikiPage/Article
  • to minimize public methods and codebase of these classes

List of work:

PS: Also, we must move all static methods to services

Event Timeline

Art-Baltai changed the task status from Open to Stalled.Mar 4 2020, 8:20 AM
Art-Baltai updated the task description. (Show Details)
Art-Baltai changed the task status from Stalled to Open.Mar 4 2020, 6:02 PM
Art-Baltai assigned this task to daniel.
Art-Baltai updated the task description. (Show Details)
Art-Baltai added subscribers: Peter.ovchyn, daniel.

This is meant as a tracking ticket, right?

@deprecated not used and looks like not Contract

What do you propose to do about these methods?

make private/protected (not has external uses)

That can only be done after the method from Article has been removed. We can only remove it after 1.35 has been branched.

This is meant as a tracking ticket, right?

Yes. The ticket is extra research on Article I did, while I was working with https://phabricator.wikimedia.org/T239975
I collected some notes about methods and properties that need to be removed or to be made private/protected

What do you propose to do about these methods?

I have already checked using of these properties/methods with https://codesearch.wmflabs.org/
We can hard deprecate it now and remove it without any consequences in ver. 1.36

That can only be done after the method from Article has been removed. We can only remove it after 1.35 has been branched.

yep, This ticket is the proposal for Article without release cycle notes

@daniel hi, can you please review this task and subtasks of it and help us identify priorities for this scope of work? Is this something we may take into the next sprint?