@Sanyam.wikime, seems like there're 4 cases of that, all in isa/templates/main/layout.html, fyi.

@Gabrielchihonglee I found six of those in layout.html (2 *.css and 4 *.js)

patch submitted at gerrit-576824

@Sanyam.wikime , ahhhh, you should change "Task-Id" in the commit message to "Bug" next time :)

Change 576824 had a related patch set uploaded (by Sanyam.wikime; owner: Sanyam.wikime):
[labs/tools/Isa@master] Replacing standard js and css libraries hosted on wmflabs with identical libraries hosted on cdnjs

https://gerrit.wikimedia.org/r/576824

Also, I think that this shouldn't be done. As we are supposed to load scripts and stylesheets through the Wikimedia cdnjs tool, it's "to ensure participants in the Cloud Services/Toolforge environment can use libraries from cdnjs.com without sacrificing the privacy called for by the Wikimedia Terms of Service".

So instead of replacing wikimedia cdnjs links to cloudflare or other providers ones, we should do the opposite.

-1. TOU issue. https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web#External_assets

However, we can consider adding some caching for out cdnjs proxy for better response times. @Bstorm thoughts?

Thanks @Gabrielchihonglee for mentioning the issue with the policy. I didn't know before about that, I viewed some other projects on Wikimedia using cdnjs.com and other external services for static part, so I suggested the same for ISA. But as stated by you, this doesn't comply with Wikimedia's policies, so should I do the opposite of that ?
Should I rename the task and description also to depict the opposite also ?

Thanks @zhuyifei1999 for reviewing the patch. I will consider the appropriate changes.

In T246885#5944433, @Sanyam.wikime wrote:

But as stated by you, this doesn't comply with Wikimedia's policies, so should I do the opposite of that ?

We would appreciate that. Thanks.

Change 577576 had a related patch set uploaded (by Sanyam.wikime; owner: Sanyam.wikime):
[labs/tools/Isa@master] Replacing url links of static assets (js ,css ) hosted on external servers to proxy links

https://gerrit.wikimedia.org/r/577576

Change 576824 abandoned by Sanyam.wikime:
Replacing url links of static assets (js ,css ) hosted on external servers to proxy links

Reason:
because the merge conflicts can not be solved automatically on web interface, so I used cli and patch is at Change 577576

https://gerrit.wikimedia.org/r/576824

Change 577576 merged by jenkins-bot:
[labs/tools/Isa@master] Replacing url links of static assets (js ,css ) hosted on external servers to proxy links

https://gerrit.wikimedia.org/r/577576

In T246885#6091945, @Gabrielchl wrote:

Seems like they don't close tasks till the patch(s) is/are deployed.

Sure, will keep it open till then.

Looks like this still hasn't been deployed to isa.toolforge.org. Anything stopping that?

In T246885#6379176, @Lokal_Profil wrote:

Looks like this still hasn't been deployed to isa.toolforge.org. Anything stopping that?

Indeed, the tool is still loading from cdnjs.cloudflare.com and stackpath.bootstrapcdn.com. Can we help with the deployment in any way?