Page MenuHomePhabricator

Changes to special pages that interact with both items/properties when federation is enabled
Closed, ResolvedPublic5 Estimated Story Points

Description

In the MVP of federated properties, only remote properties can be used when federation is enabled. Local properties are not supported and will cause issues [See T255404]. Changes to the aliases, description, and/or label of a federated property should therefore only be possible on the source Wiki.

There are four special pages that interact with both items and properties in Wikibase, all of which have misleading names when federation is enabled:

  • Special:SetAliases ("Set Item/Property aliases")
  • Special:SetDescription ("Set Item/Property description")
  • Special:SetLabel ("Set Item/Property label")
  • Special:SetLabelDescriptionAliases ("Set Item/Property label, description and aliases")

See also T253863 for the Commons version of this issue wherein the page names mention too few entity types rather than too many.

We decided to go for a more temporary solution, which is to only change these page titles when federated properties are enabled (replacing Item/Property with Item). We will address this issue again in the next phase of federation in which local properties are possible, at which point we can explore something closer to option 3 below.

BDD (Scenario: List of Special Pages)
Given My Wikibase has federated properties enabled
When I load Special:SpecialPages
Then The list includes a link to SetAliases labeled Set Item aliases
And The list includes a link to SetDescription labeled Set Item description
And The list includes a link to SetLabel labeled Set Item label
And The list includes a link to SetLabelDescriptionAliases labeled Set Item label, description and aliases

BDD (Scenario: SetAliases)
Given My Wikibase has federated properties enabled
When I load Special:SetAliases
Then The page title is displayed as Set Item Aliases
And <h1> is displayed as Set Item Aliases

Options We Considered

  1. Rename the pages to "Set Item [description, label, aliases]" -- for federated properties only, not across all Wikibase
  2. Replace item/property with entity in the page title, then list the available entity types somewhere else within the page
  3. Make pages more flexible and display the names of enabled entity types that have fingerprints and can be used with the page

Event Timeline

Samantha_Alipio_WMDE renamed this task from Hide/disable pages that don't work with federated properties to Changes to special pages that interact with both items/properties when federation is enabled.Jun 16 2020, 4:19 PM
Samantha_Alipio_WMDE updated the task description. (Show Details)
Samantha_Alipio_WMDE removed a subscriber: Jakob_WMDE.
toan removed toan as the assignee of this task.Jul 1 2020, 1:12 PM
toan added a subscriber: toan.
Addshore triaged this task as Medium priority.Jul 8 2020, 10:34 AM
Addshore claimed this task.
Addshore added a subscriber: Addshore.

Resolved as it's in the Done column at the end of sprint 3 (start of sprint 4)