Page MenuHomePhabricator

Add 'i18n-directionality.less' file to core and extract overarching theme styles from legacy.less
Open, Stalled, LowPublic


Resulting from T169910, we've started with extracting

  • 'i18n-all-lists-margins.less',
  • 'i18n-headings.less'' &
  • 'i18n-ordered-lists.less'

legacy.less still carries a number of i18n specific styles on directionality. They should be extracted as well.


  • Extract directionality styles to new file
  • Add it to legacy.less as import
  • Load it on MN as well.

Event Timeline

Change 577369 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Extract rules and add 'i18n-directionality.less'

What problem will this explicitly solve for Minerva? Can you update the description with a line that Olga can use for prioritisation? Thank you.

Change 577693 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Combine input type directionality selectors

@Volker_E could you rephrase this as a problem statement rather than a thing to do? What is the end goal of this work? Easier to maintain code or to fix a bug with an existing skin (this helps me understand your motivations).

It was my understanding that Minerva for example didn't need many of these styles in legacy as it rolls its own. Is there something specifically broken in Minerva (or another skin) that we want to fix?

I was never intending for us to copy over everything in legacy.less - my intention was to scope the new features to useful utilities and generic tag selectors e.g. h1,h2,h3,ul etc..

There is nothing stopping you pulling out LESS modules and importing them directly inside legacy.less (outside ResourceLoaderSkinModule) but the features array is supposed to force us to revisit and wean ourselves off much of the legacy code in legacy.less - a skin developer should be able to clearly grok each feature and decide whether it's useful or not to them before including it.

Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
Jdlrobson changed the task status from Open to Stalled.Apr 29 2020, 6:03 PM

I'd like to know the problem statement about this one.

@Volker_E: Could you please answer the last comments? Thanks in advance!

Change 577693 merged by jenkins-bot:
[mediawiki/core@master] Combine input type directionality selectors