Page MenuHomePhabricator

HTMLCheckboxMatrix (Preference -> Notifications must have label)
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  1. Navigate till "Your Alerts" control and hit enter.
  2. Navigate till "Preferences" control and hit enter.
  3. Navigate till "Notifications " control and hit enter.
  4. Verify using Accessibility Insights tool

Actual Results:
Checkboxes in checkboxmatrix do not have an accessible name

image.png (397×523 px, 26 KB)

Path
input[value="web-edit-user-talk"]

Snippet
<input type="checkbox" tabindex="-1" aria-disabled="true" class="oo-ui-inputWidget-input" name="wpecho-subscriptions[]" disabled="" value="web-edit-user-talk" checked="">

Path
input[value="email-edit-user-talk"]

Snippet
<input type="checkbox" tabindex="0" aria-disabled="false" class="oo-ui-inputWidget-input" name="wpecho-subscriptions[]" value="email-edit-user-talk" checked="">

Expected Results:
Checkboxes in checkboxmatrix must have an accessible name

Event Timeline

Change 577386 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Adding accessibility label to each checkbox in the checkbox matrix

https://gerrit.wikimedia.org/r/577386

Hi just want to follow up and see if we can get a set of eyes for this patch.
Thanks!

Hi just want to follow up and see if we can get a set of eyes for this patch.

Thanks for the ping! @Volker_E reviewed some of the patchsets, wondering if there's capacity (or someone else in mind who has knowledge of this code area)?

Pppery subscribed.

I know I'm years late, but see https://mediawiki.org/wiki/Code_review/patch_board if you need help getting a patch reviewed.

@Tam-edwin-microsoft: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Change #577386 abandoned by Hashar:

[mediawiki/core@master] checkmatrixwidget: Add title property to checkboxes

https://gerrit.wikimedia.org/r/577386

Change #577386 restored by Thcipriani:

[mediawiki/core@master] checkmatrixwidget: Add title property to checkboxes

https://gerrit.wikimedia.org/r/577386