Page MenuHomePhabricator

HTMLCheckboxMatrix (Preference -> Notifications must have label)
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  1. Navigate till "Your Alerts" control and hit enter.
  2. Navigate till "Preferences" control and hit enter.
  3. Navigate till "Notifications " control and hit enter.
  4. Verify using Accessibility Insights tool

Actual Results:
Checkboxes in checkboxmatrix do not have an accessible name

image.png (523×397 px, 26 KB)

Path
input[value="web-edit-user-talk"]

Snippet
<input type="checkbox" tabindex="-1" aria-disabled="true" class="oo-ui-inputWidget-input" name="wpecho-subscriptions[]" disabled="" value="web-edit-user-talk" checked="">

Path
input[value="email-edit-user-talk"]

Snippet
<input type="checkbox" tabindex="0" aria-disabled="false" class="oo-ui-inputWidget-input" name="wpecho-subscriptions[]" value="email-edit-user-talk" checked="">

Expected Results:
Checkboxes in checkboxmatrix must have an accessible name

Event Timeline

Change 577386 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[mediawiki/core@master] Adding accessibility label to each checkbox in the checkbox matrix

https://gerrit.wikimedia.org/r/577386

Hi just want to follow up and see if we can get a set of eyes for this patch.
Thanks!

Hi just want to follow up and see if we can get a set of eyes for this patch.

Thanks for the ping! @Volker_E reviewed some of the patchsets, wondering if there's capacity (or someone else in mind who has knowledge of this code area)?