Page MenuHomePhabricator
Create Task
Maniphest T247044

'Add qualifier' field displays 'Unsupported data type' default text
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. On production (e.g. https://commons.wikimedia.org/wiki/File:Malibu-superbloom.jp) or in betacluster (e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Icon_for_char_%E8%AB%B5_darkslateblue_plum_32x32.png) click on 'Structured data'.
  2. Click on 'Edit' and then on 'Add qualifier' - the field will display the default text "Unsupported data type".

Actual Results:

Screen Shot 2020-03-05 at 3.50.40 PM.png (325×828 px, 44 KB)

Expected Results:
The text should inform users what should go into this field (or it might be just blank). The existing text doesn't provide users with helpful info.

Details

SubjectRepoBranchLines +/-
Remove label from UnsupportedInputWidgetmediawiki/extensions/WikibaseMediaInfomaster+1 -4
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Mar 6 2020, 12:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2020, 12:05 AM
• Ramsey-WMF assigned this task to egardner.Mar 6 2020, 7:53 PM
• Ramsey-WMF edited projects, added Structured-Data-Backlog (Current Work), Structured Data Engineering; removed StructuredDataOnCommons.
• Ramsey-WMF added subscribers: AnneT, Cparle.

Looks like something for you, Eric 😺 (although maybe Anne as well)

egardner added a comment.Mar 6 2020, 8:15 PM

This looks like a situation where we need to apply a different label (or simply show no label at all) in the second disabled field before the user has specified a property in the first field. I propose we handle this situation like so:

  1. User is clicks "add qualifier". A new row appears with empty inputs for property and value. The value input is disabled and has no label at all.
  2. User types/selects a property. The value input updates to become an input of the appropriate type.
  3. If the user selects a type that happens to be unsupported, they see the disabled value input with "unsupported data type" message like we see here.

Can you confirm what behavior you'd like to see here?

• Ramsey-WMF added a comment.Mar 6 2020, 8:21 PM

This is exactly what I was hoping for 👇

In T247044#5949708, @egardner wrote:

This looks like a situation where we need to apply a different label (or simply show no label at all) in the second disabled field before the user has specified a property in the first field. I propose we handle this situation like so:

  1. User is clicks "add qualifier". A new row appears with empty inputs for property and value. The value input is disabled and has no label at all.
  2. User types/selects a property. The value input updates to become an input of the appropriate type.
  3. If the user selects a type that happens to be unsupported, they see the disabled value input with "unsupported data type" message like we see here.

Can you confirm what behavior you'd like to see here?

gerritbot added a comment.Mar 7 2020, 2:27 AM

Change 577715 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/WikibaseMediaInfo@master] Hide "unsupported data type" label when user adds a new qualifier

https://gerrit.wikimedia.org/r/577715

gerritbot added a project: Patch-For-Review.Mar 7 2020, 2:27 AM
egardner moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Mar 7 2020, 2:29 AM
Cparle added a comment.Mar 9 2020, 3:53 PM
This comment was removed by Cparle.
Cparle moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Mar 11 2020, 10:57 AM
gerritbot added a comment.Mar 11 2020, 8:25 PM

Change 577715 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove label from UnsupportedInputWidget

https://gerrit.wikimedia.org/r/577715

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 11 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 11 2020, 9:10 PM
Etonkovidova moved this task from To Do to Verify on Production on the Structured Data Engineering board.Mar 12 2020, 10:06 PM

Checked in betalabs - the default text is not present anymore:

Screen Shot 2020-03-12 at 1.44.50 PM.png (328×822 px, 38 KB)

Note: There is one strange issue - filed as T247574: [betalabs] SD - 'Add qualifier field' disappears after clicking on 'Cancel' (might be related to T247150: [BetaCommons] Structured Data added by anonymous users not displaying properly).

• Ramsey-WMF moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Mar 19 2020, 7:10 PM
• Ramsey-WMF closed this task as Resolved.Mar 23 2020, 6:15 PM
• Ramsey-WMF claimed this task.
• Ramsey-WMF added a subscriber: egardner.

Verified working on production.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL