As seen in T246980
CachingFallbackLabelDescriptionLookups currently goes and tries to blindly look for (or create) cached content even when the Term language is clearly invalid
As seen in T246980
CachingFallbackLabelDescriptionLookups currently goes and tries to blindly look for (or create) cached content even when the Term language is clearly invalid
As discussed with the Campsite and with @Jakob_WMDE I'm just now investigating the point of this class to try and understand if the caching functionality could be replaced by a CachingPrefetchingTermLookup instead
It appears that the only two places that this CachingFallbackLabelDescriptionLookup is used are here in the Lua Code and in \Wikibase\Lib\Formatters\ItemPropertyIdHtmlLinkFormatter
I'm trying to understand this but it appears to be almost a clone of \Wikibase\Lib\Formatters\LabelsProviderEntityIdHtmlLinkFormatter. It might therefore be possible to remove all usages of CachingFallbackLabelDescriptionLookup and replace them with the "normal" LabelDescriptionLookup from the services that are used everywhere else.
Unassigned myself because clearly I wasn't making progress on this.
I was following the path mentioned in the above comment:
See T250930 as a conceptual parent of this task. However, this task is essentially already resolved by - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/613100