Page MenuHomePhabricator
Create Task
Maniphest T247156

IPUtils test coverage is poor
Closed, ResolvedPublic
Actions

Assigned To
Reedy
Authored By
Reedy
Mar 7 2020, 11:23 AM
Tags
Referenced Files
F32357056: Screenshot 2020-09-20 at 17.06.44.png
Sep 20 2020, 4:07 PM
F31808694: Screenshot 2020-05-09 at 03.27.43.png
May 9 2020, 2:28 AM
F31806462: Screenshot 2020-05-07 at 14.46.12.png
May 7 2020, 1:46 PM
F31672091: Screenshot 2020-03-09 at 01.33.41.png
Mar 9 2020, 1:34 AM
F31671824: Screenshot 2020-03-08 at 22.12.51.png
Mar 8 2020, 10:13 PM
F31671621: Screenshot 2020-03-08 at 20.04.21.png
Mar 8 2020, 8:04 PM
F31671601: Screenshot 2020-03-08 at 19.47.55.png
Mar 8 2020, 7:49 PM
Subscribers
Aklapper
Reedy

Description

As of task creation, https://doc.wikimedia.org/cover/mediawiki-libs-IPUtils/ was only 50-55 ish percent

While in some functions testing for explicit ranges is accepted, it's not tested at all

None of the examples at https://github.com/wikimedia/mediawiki-libs-IPUtils/blob/cb861b9/tests/IPUtilsTest.php#L258-L277 include an -, similarly in https://github.com/wikimedia/mediawiki-libs-IPUtils/blob/cb861b9/tests/IPUtilsTest.php#L294-L309

Looking at T247149, which requests 185.153.192.0-60 (which has to be 185.153.192.0-185.153.192.60) to work https://github.com/wikimedia/mediawiki-libs-IPUtils/blob/cb861b9/src/IPUtils.php#L487-L557 mentions 1.2.3.4 - 1.2.3.5 Explicit range

It seems prudent to actually have test cases to test a large swathe of code :)

Before:

Screenshot 2020-03-08 at 19.47.55.png (296×2 px, 76 KB)

Currently:

Screenshot 2020-09-20 at 17.06.44.png (296×2 px, 83 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add test for another edge case of IPUtils::parseRange()mediawiki/libs/IPUtilsmaster+1 -0
Mark IPUtilsTest::testToHex() as covering IPUtils:IPv6ToRawHex()mediawiki/libs/IPUtilsmaster+1 -0
Add case for IPUtils::parseCIDR() being given IPv6mediawiki/libs/IPUtilsmaster+3 -0
Add tests for IPUtils::parseRange() for single IPsmediawiki/libs/IPUtilsmaster+3 -0
IPUtils: Improve test coveragemediawiki/libs/IPUtilsmaster+3 -0
tests: Add IPv6 coverage of sanitizeIP()mediawiki/libs/IPUtilsmaster+2 -0
Add tests to cover IPUtils::parseRangemediawiki/libs/IPUtilsmaster+44 -1
Allow explicit ranges in IPUtils::isValidRange()mediawiki/libs/IPUtilsmaster+13 -3
Add some test casesmediawiki/libs/IPUtilsmaster+0 -0
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Mar 7 2020, 11:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2020, 11:23 AM
Reedy updated the task description. (Show Details)Mar 7 2020, 11:28 AM
Reedy added a project: archived-IPUtils.Mar 7 2020, 11:33 AM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Mar 7 2020, 11:35 AM
Reedy updated the task description. (Show Details)
gerritbot added a comment.Mar 7 2020, 11:39 AM

Change 577749 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Add some test cases

https://gerrit.wikimedia.org/r/577749

gerritbot added a project: Patch-For-Review.Mar 7 2020, 11:39 AM
gerritbot added a comment.Mar 7 2020, 11:49 AM

Change 577749 abandoned by Reedy:
Add some test cases

https://gerrit.wikimedia.org/r/577749

Reedy renamed this task from IPUtils doesn't have tests for explicit ranges to IPUtils test coverage is poor.Mar 7 2020, 12:06 PM
gerritbot added a comment.Mar 7 2020, 12:07 PM

Change 577752 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Add tests to cover IPUtils::parseRange

https://gerrit.wikimedia.org/r/577752

Reedy updated the task description. (Show Details)Mar 7 2020, 12:09 PM
Reedy added a project: Test-Coverage.Mar 7 2020, 12:24 PM
gerritbot added a comment.Mar 7 2020, 1:46 PM

Change 577774 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Allow explicit ranges in IPUtils::isValidRange()

https://gerrit.wikimedia.org/r/577774

Reedy updated the task description. (Show Details)Mar 8 2020, 7:49 PM
gerritbot added a comment.Mar 8 2020, 7:52 PM

Change 577774 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Allow explicit ranges in IPUtils::isValidRange()

https://gerrit.wikimedia.org/r/577774

Reedy mentioned this in rMLIP1f074b17a6fa: Allow explicit ranges in IPUtils::isValidRange().Mar 8 2020, 7:53 PM
gerritbot added a comment.Mar 8 2020, 8:00 PM

Change 577752 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Add tests to cover IPUtils::parseRange

https://gerrit.wikimedia.org/r/577752

Jdforrester-WMF mentioned this in rMLIP31ff91473244: Add tests to cover IPUtils::parseRange.Mar 8 2020, 8:00 PM
Reedy added a comment.Mar 8 2020, 8:04 PM

Progress! (on lines at least)

Screenshot 2020-03-08 at 19.47.55.png (296×2 px, 76 KB)

to

Screenshot 2020-03-08 at 20.04.21.png (288×2 px, 75 KB)

gerritbot added a comment.Mar 8 2020, 8:26 PM

Change 578110 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/libs/IPUtils@master] Bug: T247156

https://gerrit.wikimedia.org/r/578110

gerritbot added a comment.Mar 8 2020, 8:29 PM

Change 578110 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/libs/IPUtils@master] tests: Add IPv6 coverage of sanitizeIP()

https://gerrit.wikimedia.org/r/578110

gerritbot added a comment.Mar 8 2020, 8:35 PM

Change 578110 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] tests: Add IPv6 coverage of sanitizeIP()

https://gerrit.wikimedia.org/r/578110

Jdforrester-WMF mentioned this in rMLIPf76ecc1209b5: tests: Add IPv6 coverage of sanitizeIP().Mar 8 2020, 8:36 PM
Reedy removed a project: Patch-For-Review.Mar 8 2020, 9:33 PM
Reedy added a comment.Mar 8 2020, 10:13 PM

Screenshot 2020-03-08 at 19.47.55.png (296×2 px, 76 KB)

to

Screenshot 2020-03-08 at 20.04.21.png (288×2 px, 75 KB)

to

Screenshot 2020-03-08 at 22.12.51.png (300×2 px, 78 KB)

Reedy added a comment.Mar 9 2020, 1:34 AM

Screenshot 2020-03-09 at 01.33.41.png (296×2 px, 78 KB)

Definitely looking in better shape in terms of lines...

Reedy mentioned this in T247212: Make new IPUtils release.Mar 9 2020, 1:34 AM
Reedy updated the task description. (Show Details)Mar 9 2020, 5:13 PM
gerritbot added a comment.May 7 2020, 8:29 AM

Change 594895 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/libs/IPUtils@master] IPUtils: Improve test coverage

https://gerrit.wikimedia.org/r/594895

gerritbot added a project: Patch-For-Review.May 7 2020, 8:29 AM
Reedy added a comment.May 7 2020, 1:46 PM

master as of writing

Screenshot 2020-05-07 at 14.46.12.png (330×2 px, 77 KB)

Reedy updated the task description. (Show Details)May 7 2020, 2:04 PM
Reedy updated the task description. (Show Details)
gerritbot added a comment.May 7 2020, 3:48 PM

Change 594895 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] IPUtils: Improve test coverage

https://gerrit.wikimedia.org/r/594895

gerritbot added a comment.May 7 2020, 3:55 PM

Change 594991 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Add tests for IPUtils::parseRange() for single IPs

https://gerrit.wikimedia.org/r/594991

gerritbot added a comment.May 7 2020, 3:59 PM

Change 594991 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Add tests for IPUtils::parseRange() for single IPs

https://gerrit.wikimedia.org/r/594991

gerritbot added a comment.May 7 2020, 4:27 PM

Change 594996 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Add case for IPUtils::parseCIDR() being given IPv6

https://gerrit.wikimedia.org/r/594996

Reedy mentioned this in rMLIPb8eb940b595a: IPUtils: Improve test coverage.May 7 2020, 5:08 PM
Reedy mentioned this in rMLIP50c5e8aacd4c: Add tests for IPUtils::parseRange() for single IPs.
gerritbot added a comment.May 9 2020, 2:18 AM

Change 594996 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Add case for IPUtils::parseCIDR() being given IPv6

https://gerrit.wikimedia.org/r/594996

Reedy mentioned this in rMLIP18d95d8ba362: Add case for IPUtils::parseCIDR() being given IPv6.May 9 2020, 2:19 AM
Reedy added a comment.May 9 2020, 2:28 AM

Screenshot 2020-05-09 at 03.27.43.png (288×2 px, 81 KB)

Reedy updated the task description. (Show Details)May 9 2020, 2:28 AM
gerritbot added a comment.May 9 2020, 2:32 AM

Change 595250 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Add test for another edge case of IPUtils::parseRange()

https://gerrit.wikimedia.org/r/595250

gerritbot added a comment.May 9 2020, 2:35 AM

Change 595251 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Mark IPUtilsTest::testToHex() as covering IPUtils:IPv6ToRawHex()

https://gerrit.wikimedia.org/r/595251

gerritbot added a comment.May 9 2020, 2:49 AM

Change 595251 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Mark IPUtilsTest::testToHex() as covering IPUtils:IPv6ToRawHex()

https://gerrit.wikimedia.org/r/595251

gerritbot added a comment.May 9 2020, 2:49 AM

Change 595250 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Add test for another edge case of IPUtils::parseRange()

https://gerrit.wikimedia.org/r/595250

Reedy mentioned this in rMLIP89201a847394: Mark IPUtilsTest::testToHex() as covering IPUtils:IPv6ToRawHex().May 9 2020, 2:51 AM
Reedy mentioned this in rMLIPf669951a435b: Add test for another edge case of IPUtils::parseRange().
Reedy closed this task as Resolved.Sep 20 2020, 4:07 PM
Reedy claimed this task.

Screenshot 2020-09-20 at 17.06.44.png (296×2 px, 83 KB)

Definitely not poor anymore

Reedy updated the task description. (Show Details)Sep 20 2020, 4:07 PM
Reedy removed a project: Patch-For-Review.Sep 20 2020, 4:10 PM
Krinkle edited projects, added MediaWiki-libs-IPUtils; removed archived-IPUtils.Jan 3 2024, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits