Page MenuHomePhabricator

Add range support to resetAuthenticationThrottle.php
Open, LowPublic

Description

In the case of tasks like T247149: Throttle rule for 2020-03-09 - Senior Citizens Write Wikipedia course, it'd be useful if resetAuthenticationThrottle.php had range support, rather than having to send it a list of ips (directly or through a loop), so. can do --ip=10.0.0.0/24 or similar, and have the script iterate over the range..

Might want to add support to IPUtils to do something like "get a range of ips from this range" which would return an array of all the ips.... Will file tasks for that

Event Timeline

Reedy triaged this task as Low priority.Mar 7 2020, 12:55 PM

Change 583519 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] resetAuthenticationThrottle.php: Add support for IP ranges

https://gerrit.wikimedia.org/r/583519

@Reedy, T247162 has been merged since but the lib has not been updated in MediaWiki. So phan is failing for r583519 since it cannot find the method. When will this be updated?

@Reedy, T247162 has been merged since but the lib has not been updated in MediaWiki. So phan is failing for r583519 since it cannot find the method. When will this be updated?

When T248237: IPUtils >=2.0.0 test failures on MW core/https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/582528/ are resolved

@Reedy, T247162 has been merged since but the lib has not been updated in MediaWiki. So phan is failing for r583519 since it cannot find the method. When will this be updated?

When T248237: IPUtils >=2.0.0 test failures on MW core/https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/582528/ are resolved

I guess these are now done

Change 583519 abandoned by Ammarpad:

[mediawiki/core@master] resetAuthenticationThrottle.php: Add support for IP ranges

Reason:

https://gerrit.wikimedia.org/r/583519

Ammarpad added a subscriber: Ammarpad.
Ammarpad removed a subscriber: Ammarpad.