IPUtils allows illegal value for netmask (/0)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 7 2020, 1:56 PM

Description

30.242.52.14/0 is a "valid" range in our tests... But it's not a legal value

Amusingly, the comment says it doesn't accept it...

	/**
	 * An IPv4 range is an IP address and a prefix (d1 to d32)
	 * @private
	 */
	const RE_IP_PREFIX = '(3[0-2]|[12]?\d)';
	/** @private */

	Subject	Repo	Branch	Lines +/-
	Stop allowing invalid /0 subnet	mediawiki/libs/IPUtils	master	+4 -4
	UserNameUtilsTest: Remove /0 from valid ranges	mediawiki/core	master	+0 -2

Mentioned In: T267997: IPUtils doesn't allow /0
rMLIP29626067b7f8: Stop allowing invalid /0 subnet

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2020, 1:56 PM

Change 577778 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Stop allowing invalid /0 subnet

Change 577778 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Stop allowing invalid /0 subnet

Reedy closed this task as Resolved.Mar 8 2020, 7:49 PM

Reedy claimed this task.

Change 641322 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] UserNameUtilsTest: Remove /0 from valid ranges

Change 641322 abandoned by Reedy:
[mediawiki/core@master] UserNameUtilsTest: Remove /0 from valid ranges

Reason: