Page MenuHomePhabricator

Pressing close ('x') on VE mobile, then pressing "continue editing", results in wrong URL
Closed, ResolvedPublic

Description

  1. Open Mobile VE
  2. Make a change
  3. Try to close the editor with the toolbar button
  4. When you are warned you will lose your changes, choose to not close the editor
  5. Notice that the URL has changed even though you didn't close the editor
  6. Try again to close the editor again and nothing happens (or you get a system warning because it's trying to go back to the previous page)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF added a subscriber: JTannerWMF.

How common an issue do you think this is @Esanders ? How did you encounter this issue? Based on what you arrive at we will prioritize this task.

This also affects using the back button. That issue is also present on desktop.

Probably related to this, if the editor fails to load for any reason, the page navigates back to wherever you were before you loaded the article.

Change 628860 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Don't navigate back immediately when trying to teardown

https://gerrit.wikimedia.org/r/628860

The above patch fixes the functionality of the close button in the toolbar, but it does not fix the browser back button. To fix that we will need to make fixes in MF to push the recently-popped state, as history.back can't be cancelled (along the lines of what was done in T263464).

Esanders renamed this task from VE mobile breaks if you abandon closing the editor to VE mobile breaks if you abandon closing the editor with the toolbar button.Sep 21 2020, 3:27 PM
Esanders updated the task description. (Show Details)
Esanders renamed this task from VE mobile breaks if you abandon closing the editor with the toolbar button to Pressing close ('x') on VE mobile, then pressing "continue editing", results in wrong URL.Sep 21 2020, 3:32 PM

The above patch fixes the functionality of the close button in the toolbar, but it does not fix the browser back button.

This is filed as T263470 now.

Change 628860 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't navigate back immediately when trying to teardown

https://gerrit.wikimedia.org/r/628860