Page MenuHomePhabricator

Enable phan and seccheck on IPUtils
Closed, ResolvedPublic

Description

As above

Event Timeline

Reedy renamed this task from Enable Phan on IPUtils to Enable phan and seccheck on IPUtils.Mar 8 2020, 7:56 PM

Change 578103 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/libs/IPUtils@master] Add phan

https://gerrit.wikimedia.org/r/578103

Current issues still to fix:

21:22:06 src/IPUtils.php:242 PhanTypeMismatchArgumentNullableInternal Argument 2 ($subject) is ?string but \preg_match() takes string (expected type to be non-nullable)
21:22:06 src/IPUtils.php:246 PhanTypeMismatchArgumentInternal Argument 1 ($string) is false but \strlen() takes string
21:22:06 src/IPUtils.php:255 PhanTypeMismatchArgumentNullableInternal Argument 1 ($str) is ?string but \substr_replace() takes string|string[] (expected type to be non-nullable)
21:22:06 src/IPUtils.php:262 PhanTypeMismatchArgumentNullableInternal Argument 1 ($str) is ?string|?string[] but \strtolower() takes string (expected type to be non-nullable)
21:22:06 src/IPUtils.php:511 PhanTypeInvalidRightOperandOfNumericOp Invalid operator: right operand of - is non-empty-string (expected number)
21:22:06 src/IPUtils.php:604 PhanTypeMismatchArgumentInternal Argument 3 ($length) is non-empty-string but \substr() takes int

Change 578103 merged by jenkins-bot:
[mediawiki/libs/IPUtils@master] Add phan and fix issues

https://gerrit.wikimedia.org/r/578103

Reedy claimed this task.