Page MenuHomePhabricator
Create Task
Maniphest T247278

"Pending AJAX requests" error from VisualEditor tests
Closed, ResolvedPublic
Actions

Description

This flaky failure affected a MediaWiki core commit earlier today at change 577702.

Jenkins build:

DEBUG [middleware:source-files]: Requesting /api.php?action=query&format=json&titles=whee
DEBUG [middleware:source-files]: Fetching /api.php
DEBUG [proxy]: proxying request - /api.php?action=query&format=json&titles=whee to 127.0.0.1:9412

…
  ve.ui.MWWikitextStringTransferHandler (Cite)
    ✖ convert
…
INFO:backend.DevWebServer: … [200]: /api.php?action=query&format=json&titles=whee

…

FAILED TESTS:
  ve.ui.MWWikitextStringTransferHandler (Cite)
    ✖ convert
      HeadlessChrome 73.0.3683 (Linux 0.0.0)
    afterEach failed on convert: Pending AJAX requests: 0 (active: 1)
    Error: Pending AJAX requests: 0 (active: 1)

When querying Codesearch for the whee phrase in files matching test.*js$ the only result is:

ve.ui.FragmentInspector.test.js
QUnit.module( 've.ui.FragmentInspector (MW)'  …
QUnit.test( 'Wikitext link inspector' …
{
				msg: 'Piped link modified',
				name: 'wikitextLink',
				range: new ve.Range( 16 ),
				input: function () {
					this.annotationInput.getTextInputWidget().setValue( 'whee' );
				},

See also:

Details

SubjectRepoBranchLines +/-
Use fake server for link inspector testsmediawiki/extensions/VisualEditormaster+12 -5
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Mar 10 2020, 1:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2020, 1:42 AM
Krinkle added a project: Wikimedia-production-error (ARCHIVED -- Shared Build Failure).Mar 10 2020, 1:42 AM
Krinkle moved this task from Untriaged to In progress on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.Mar 10 2020, 3:11 PM
JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.
JTannerWMF moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex subscribed.EditedMar 10 2020, 7:26 PM

I had a quick look and I don't see how this is happening.

For reference, that test simulates opening the link inspector in VE, optionally typing some text into it, and then closing it.

As far as I can tell, the test waits for the inspector to close before it finishes (1), and the inspector aborts any still pending requests while closing (2), and the requests are meticulously kept track of so that they can actually be aborted (3).

  • (1) ve.test.utils.runFragmentInspectorTests: return inspector.teardown( caseItem.actionData || { action: 'done' } )…
  • (2) ve.ui.LinkAnnotationInspector.prototype.getTeardownProcess: this.annotationInput.setAnnotation( null ); which eventually calls OO.ui.mixin.RequestManager.prototype.abortRequest
  • (3) mw.widgets.TitleWidget.prototype.getSuggestionsPromise: note how promiseAbortObject.abort is reassigned

This specific request comes from this line in mw.widgets.TitleWidget.prototype.getSuggestionsPromise: ret = api.get( { action: 'query', titles: query } );.

JTannerWMF edited projects, added Editing-team (Tracking); removed Editing-team (Q3 2019-2020 Kanban Board).Mar 24 2020, 5:11 PM
JTannerWMF moved this task from Backlog to Dependent on others on the Editing-team (Tracking) board.
JTannerWMF subscribed.

This is waiting on some guidance from @Krinkle

Krinkle updated the task description. (Show Details)Mar 24 2020, 9:42 PM
Krinkle added a comment.Mar 24 2020, 9:52 PM

There is no doubt that the reported QUnit error about untracked HTTP request is an HTTP request from VisualEditor.

I'm happy to help investigate or offer advice on how to do investigate something, but there is not currently a question for me to answer. What is it you'd like me to do?

It is extra hard to get exra data right now as we consistently reproduce it. in CI However this and other infrequent failures together do affect overall CI stability and developer productivity. Having to wait two or three times for 20 minutes, instead of only once quickly makes a big difference in what one can do in a day.

Some general things to perhaps consider if you haven't already:

  • Does the test use Sinon sandboxes for clocks? If so, perhaps they need additional ticks to consistently resolve the promise object in time.
  • Does the result of the ajax request affect the asserted end-result, or is it just a side-effect that has to happen but isn't used? If so, perhaps the mw.Api method or the higher-level getSuggestionsPromise method could be stubbed out.
  • Does the result need to come from the live MW server? If not, consider using Sinon's "Fake server". See mediawiki.api.options.test.js in MediaWiki core for an example. In a nut shell, you'd enable it from the test setup, and then for tests that need it, you'd specify a partial or full request match with a simulated JSON response. This way eliminates any actual XHR requests from being left behind.

@matmarex Hope that helps :)

Krinkle added a comment.Apr 13 2020, 4:16 PM

This is still failing in CI and randomly preventing patches from being reviewed/merged. Latest at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/584677/ for example.

Krinkle moved this task from Tracking to Untriaged on the Editing-team board.Apr 13 2020, 4:17 PM
Krinkle edited projects, added Editing-team; removed Editing-team (Tracking).
Krinkle edited projects, added ci-test-error (WMF-deployed Build Failure); removed Wikimedia-production-error (ARCHIVED -- Shared Build Failure), ci-test-error.Apr 18 2020, 10:53 PM
matmarex edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.Apr 21 2020, 8:19 PM
• Pablo-WMDE subscribed.Apr 22 2020, 7:27 AM

Did not really dive into this ticket, but "Pending AJAX requests", the description and the "QUnit" buzzword remind me of T250305.

gerritbot added a comment.May 20 2020, 2:55 PM

Change 597562 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use fake server for link inspector tests

https://gerrit.wikimedia.org/r/597562

gerritbot added a project: Patch-For-Review.May 20 2020, 2:55 PM
gerritbot added a comment.May 20 2020, 3:51 PM

Change 597562 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use fake server for link inspector tests

https://gerrit.wikimedia.org/r/597562

Jdforrester-WMF subscribed.May 20 2020, 3:55 PM

As we have no way to reliably trigger this, it's hard to determine if it's now fixed…

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 20 2020, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 20 2020, 4:10 PM
matmarex moved this task from Ready for Development to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.May 20 2020, 4:54 PM
• ppelberg closed this task as Resolved.May 21 2020, 11:32 PM
• ppelberg claimed this task.
• ppelberg subscribed.
In T247278#6152753, @Jdforrester-WMF wrote:

As we have no way to reliably trigger this, it's hard to determine if it's now fixed…

Resolving this for now. Please comment if you think something else should be done.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 21 2020, 11:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL