Page MenuHomePhabricator

Filters on Special:Investigate should validate users
Closed, ResolvedPublicMar 20 2020

Description

Problem
The filters on Special:Investigate do not validate that the users exist.

Solution
On uses of HTMLUsersMultiselectField set exists to true and required to false.

Event Timeline

Change 578403 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Set exists to true for filters on Special:Investigate.

https://gerrit.wikimedia.org/r/578403

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 578403 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Set exists to true for filters on Special:Investigate.

https://gerrit.wikimedia.org/r/578403

dom_walden added a subscriber: dom_walden.

Testing different inputs to the Compare filters on my local vagrant: MediaWiki 1.35.0-alpha (5e1e15e).

InputOutcome
EmptySubmits; No change to output or SQL before and after
Non-existent user/IPSubmits; No change to output or SQL before and after
Existent user/IPSubmits; Filters out user/IP as appropriate
Existent + non-existentSubmits; Only filters out existent user/IP