Page MenuHomePhabricator
Create Task
Maniphest T247312

Make MediaWiki-Docker as the default for Selenium framework
Closed, DuplicatePublic
Actions

Description

Status

1/29 repositories (3%)

Notes

At the moment, mediawiki-vagrant is the default. We want to make mediawiki-docker the default.

mediawiki-docker uses .env file:

MW_SCRIPT_PATH=/w
MW_SERVER=http://localhost:8080
MEDIAWIKI_USER=Admin
MEDIAWIKI_PASSWORD=dockerpass

Instead of using hard-coded values in wdio.conf.js, use valuse from .env file.

wdio.conf.js

mwUser: process.env.MEDIAWIKI_USER || 'Admin',
mwPwd: process.env.MEDIAWIKI_PASSWORD || 'vagrant',
...
baseUrl: ( process.env.MW_SERVER || 'http://127.0.0.1:8080' ) + (process.env.MW_SCRIPT_PATH || '/w'

Check if we're already using an NPM package for parsing .env files. If yes, use it. If no, find one. (Example: dotenv.) Replace values for above environment variables with the ones from .env.

Instructions

Refer https://www.mediawiki.org/wiki/Selenium/Getting_Started/Run_tests_targeting_MediaWiki-Docker

Repositories

  • mediawiki/core 643576
  • mediawiki/extensions/AbuseFilter 644303
  • mediawiki/extensions/AdvancedSearch 644314
  • mediawiki/extensions/CirrusSearch
  • mediawiki/extensions/Cite
  • mediawiki/extensions/CodeMirror
  • mediawiki/extensions/Echo
  • mediawiki/extensions/ElectronPdfService
  • mediawiki/extensions/EntitySchema
  • mediawiki/extensions/FileImporter
  • mediawiki/extensions/GrowthExperiments
  • mediawiki/extensions/Math
  • mediawiki/extensions/MobileFrontend
  • mediawiki/extensions/Newsletter
  • mediawiki/extensions/Popups
  • mediawiki/extensions/ProofreadPage
  • mediawiki/extensions/RelatedArticles
  • mediawiki/extensions/RevisionSlider
  • mediawiki/extensions/TemplateWizard
  • mediawiki/extensions/TwoColConflict
  • mediawiki/extensions/Wikibase
  • mediawiki/extensions/WikibaseLexeme
  • mediawiki/extensions/WikibaseMediaInfo
  • mediawiki/skins/MinervaNeue
  • phabricator/deployment
  • wikibase/termbox
  • wikidata/query/gui
  • wikimedia/portals/deploy
  • wmde/wdio-wikibase

TODO

Details

SubjectRepoBranchLines +/-
Selenium: Target Mediawiki-Docker by defaultmediawiki/extensions/AdvancedSearchmaster+10 -1
Selenium: Target Mediawiki-Docker by defaultmediawiki/extensions/AbuseFiltermaster+13 -4
Selenium: Target Mediawiki-Docker by defaultmediawiki/coremaster+12 -4
Customize query in gerrit

Related Objects

Event Timeline

zeljkofilipin created this task.Mar 10 2020, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2020, 3:00 PM
zeljkofilipin triaged this task as Medium priority.Mar 10 2020, 3:00 PM
zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.Mar 10 2020, 3:11 PM
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
zeljkofilipin moved this task from Q4 👔 to Backlog 🪒 on the User-zeljkofilipin board.Apr 29 2020, 1:52 PM
zeljkofilipin added a project: MediaWiki-Docker.Sep 29 2020, 9:59 AM
zeljkofilipin mentioned this in T210726: Selenium framework cleanup.Oct 15 2020, 4:29 PM
Addshore subscribed.Oct 28 2020, 5:33 PM

It might be nice to add a bit of extra logic somewhere in this stack to make this automatically discoverable and configured no matter which one of the commons dev environments you use, rather than switching from one hard coding to another.

Soham assigned this task to Harriet.Nov 25 2020, 11:11 AM
Soham updated the task description. (Show Details)Nov 25 2020, 11:13 AM
Soham updated the task description. (Show Details)Nov 25 2020, 11:20 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptNov 25 2020, 11:20 AM
Soham updated the task description. (Show Details)Nov 25 2020, 11:22 AM
gerritbot added a comment.Nov 25 2020, 10:41 PM

Change 643576 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/core@master] Change the values of some environment variables in wdio.conf.js file

https://gerrit.wikimedia.org/r/643576

gerritbot added a project: Patch-For-Review.Nov 25 2020, 10:41 PM
Soham subscribed.Nov 26 2020, 9:29 AM
In T247312#6585628, @Addshore wrote:

It might be nice to add a bit of extra logic somewhere in this stack to make this automatically discoverable and configured no matter which one of the commons dev environments you use, rather than switching from one hard coding to another.

@Addshore I am not sure I understand what you meant but the suggestion seems interesting. Can you explain a bit more here?

kostajh subscribed.Nov 26 2020, 10:18 AM

This task and its patch shouldn't be needed. MediaWiki-Docker instructs you to write a .env file with

export MW_SERVER=http://localhost:8080
export MW_SCRIPT_PATH=/
export MEDIAWIKI_USER=Admin
export MEDIAWIKI_PASSWORD=dockerpass

wdio.conf.js should read from that, and if those env variables aren't set then it falls back to settings relevant to Vagrant.

(Side note: as of a month or two ago, MW_SCRIPT_PATH should be /w for MediaWiki-Docker, just like it is for Vagrant)

zeljkofilipin updated the task description. (Show Details)Nov 26 2020, 11:01 AM
zeljkofilipin updated the task description. (Show Details)Nov 26 2020, 11:04 AM
zeljkofilipin updated the task description. (Show Details)Nov 26 2020, 11:07 AM
zeljkofilipin moved this task from Backlog 🪒 to Learn/Teach 💡 on the User-zeljkofilipin board.Nov 26 2020, 3:04 PM

Thanks @kostajh, that's a great idea! I've updated the task description.

gerritbot added a comment.Nov 30 2020, 6:25 PM

Change 644303 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/extensions/AbuseFilter@master] Selenium: Target Mediawiki-Docker by default

https://gerrit.wikimedia.org/r/644303

gerritbot added a comment.Nov 30 2020, 7:19 PM

Change 644314 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/extensions/AdvancedSearch@master] Selenium: Target Mediawiki-Docker by default

https://gerrit.wikimedia.org/r/644314

WMDE-Fisch subscribed.Dec 1 2020, 9:26 AM
In T247312#6656878, @gerritbot wrote:

Change 644314 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/extensions/AdvancedSearch@master] Selenium: Target Mediawiki-Docker by default

https://gerrit.wikimedia.org/r/644314

Hej @Harriet sorry to stop you here, but as I understood the last comment by @kostajh, this task is _not_ about changing the default/fallback in the wdio.conf from using the Vagrant settings.

wdio.conf.js should read from that, and if those env variables aren't set then it falls back to settings relevant to Vagrant.

Vidhi-Mody subscribed.Dec 1 2020, 10:21 AM
Soham added a comment.EditedDec 1 2020, 10:24 AM
In T247312#6658601, @WMDE-Fisch wrote:
In T247312#6656878, @gerritbot wrote:

Change 644314 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/extensions/AdvancedSearch@master] Selenium: Target Mediawiki-Docker by default

https://gerrit.wikimedia.org/r/644314

Hej @Harriet sorry to stop you here, but as I understood the last comment by @kostajh, this task is _not_ about changing the default/fallback in the wdio.conf from using the Vagrant settings.

wdio.conf.js should read from that, and if those env variables aren't set then it falls back to settings relevant to Vagrant.

@WMDE-Fisch Since we officially support Mediaiwiki-Docker, the aim here is to fallback to Mediawiki-Docker by default instead of Mediawiki-Vagrant

WMDE-Fisch added a comment.Dec 1 2020, 10:33 AM
In T247312#6658817, @Soham wrote:
In T247312#6658601, @WMDE-Fisch wrote:
In T247312#6656878, @gerritbot wrote:

Change 644314 had a related patch set uploaded (by Harriet Ayugi; owner: Harriet Ayugi):
[mediawiki/extensions/AdvancedSearch@master] Selenium: Target Mediawiki-Docker by default

https://gerrit.wikimedia.org/r/644314

Hej @Harriet sorry to stop you here, but as I understood the last comment by @kostajh, this task is _not_ about changing the default/fallback in the wdio.conf from using the Vagrant settings.

wdio.conf.js should read from that, and if those env variables aren't set then it falls back to settings relevant to Vagrant.

@WMDE-Fisch Since we officially support Mediaiwiki-Docker, the aim here is to fallback to Mediawiki-Docker by default instead of Mediawiki-Vagrant

Thanks for the clarification! Then I guess that the task should be updated to reflect that. :-)

Soham renamed this task from MediaWiki-Docker is the default for Selenium framework to Make MediaWiki-Docker as the default for Selenium framework.Dec 1 2020, 10:39 AM

@WMDE-Fisch thanks for pointing it out. I've changed the task title

zeljkofilipin updated the task description. (Show Details)Dec 3 2020, 10:20 AM
gerritbot added a comment.Dec 8 2020, 4:11 PM

Change 643576 merged by jenkins-bot:
[mediawiki/core@master] Selenium: Target Mediawiki-Docker by default

https://gerrit.wikimedia.org/r/643576

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 8 2020, 5:01 PM
zeljkofilipin moved this task from Learn/Teach 💡 to Deep work 🌊 on the User-zeljkofilipin board.Dec 10 2020, 10:19 AM
zeljkofilipin added a comment.Dec 23 2020, 6:29 PM
In T247312#6585628, @Addshore wrote:

It might be nice to add a bit of extra logic somewhere in this stack to make this automatically discoverable and configured no matter which one of the commons dev environments you use, rather than switching from one hard coding to another.

That's what we did at the end, the framework reads .env file.

zeljkofilipin updated the task description. (Show Details)Dec 23 2020, 6:30 PM
zeljkofilipin updated the task description. (Show Details)Dec 23 2020, 6:33 PM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin removed Harriet as the assignee of this task.Jan 15 2021, 12:28 PM
zeljkofilipin added a subscriber: Harriet.
brennen added a project: User-brennen.Jan 15 2021, 9:28 PM
brennen moved this task from Backlog to Radar on the User-brennen board.
brennen subscribed.
zeljkofilipin claimed this task.Mar 23 2021, 3:02 PM
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)Mar 23 2021, 4:38 PM
zeljkofilipin removed zeljkofilipin as the assignee of this task.Mar 23 2021, 5:59 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.
zeljkofilipin claimed this task.Mar 24 2021, 1:49 PM
zeljkofilipin moved this task from Radar to Doing on the User-brennen board.
zeljkofilipin moved this task from Doing to Radar on the User-brennen board.
zeljkofilipin moved this task from Waiting 🏹 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin removed zeljkofilipin as the assignee of this task.Mar 29 2021, 11:10 AM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)Mar 29 2021, 1:16 PM
Krinkle subscribed.Apr 13 2021, 11:29 PM
gerritbot added a comment.May 6 2021, 4:26 PM

Change 644303 abandoned by Zfilipin:

[mediawiki/extensions/AbuseFilter@master] Selenium: Target Mediawiki-Docker by default

Reason:

Replaced by T281484.

https://gerrit.wikimedia.org/r/644303

gerritbot added a comment.May 6 2021, 4:26 PM

Change 644314 abandoned by Zfilipin:

[mediawiki/extensions/AdvancedSearch@master] Selenium: Target Mediawiki-Docker by default

Reason:

Replaced by T281484.

https://gerrit.wikimedia.org/r/644314

zeljkofilipin added a parent task: T281484: Add a basic wdio.conf.js to wdio-mediawiki.May 6 2021, 4:27 PM
zeljkofilipin closed this task as a duplicate of T281484: Add a basic wdio.conf.js to wdio-mediawiki.
zeljkofilipin removed a parent task: T281484: Add a basic wdio.conf.js to wdio-mediawiki.May 6 2021, 4:33 PM
zeljkofilipin mentioned this in T281484: Add a basic wdio.conf.js to wdio-mediawiki.May 6 2021, 4:43 PM
Maintenance_bot removed a project: Patch-For-Review.May 6 2021, 5:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL