Page MenuHomePhabricator

QA fundraising banners with new header and collapsible sidebar
Closed, ResolvedPublic

Description

Background

As a part of the desktop improvements project, we would like to ensure that the changes we are making do not affect the way that central notice and other fundraising banners appear on the page. This task is to QA the banners along with the first two changes we are making.

Acceptance criteria

  • copy over the fundraising banners to the beta cluster
  • QA banners along with collapsible sidebar and new header
  • QA steps:
  • Go to enwiki beta cluster and append ?banner=fundraising_dsk_lg&country=GB to banner
  • Test with sidebar open/closed
  • Test on at least one special page
  • Repeat the above with url ?banner=fundraising_dsk_sm&country=GB
  • Repeat steps 1-4 on hewiki beta cluster

Event Timeline

ovasileva triaged this task as Medium priority.Mar 10 2020, 4:44 PM
ovasileva added a project: Readers-Web-Backlog.
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
ovasileva added a subscriber: Edtadros.

Putting in triaged but future until work on the sidebar is completed.

I copied our current desktop banners over to beta cluster (large, small) along with English, French and Hebrew translations. They can be viewed by adding ?banner=fundraising_dsk_lg or ?banner=fundraising_dsk_sm to the URL on any beta site.

Unfortunately there doesn't appear to be a French Wikipedia on the beta cluster to test with. There is a Hebrew Wikipedia, I imported the Albert Einstein article to give something to test with:

It doesn't look like there's any desktop improvements changes on the beta cluster yet, let me know when there are if you want any help testing!

@ovasileva, here's what I'm seeing. I have a pass next to the Large Banner cases, but they have odd looking links like this:

QA steps:
❓ AC1: Go to enwiki and hewiki beta cluster and append ?banner=fundraising_dsk_lg&country=GB to banner with sidebar expanded

LARGE
ENHE
NOTE: The HE banner does not contain a "Maybe Later" link. See below.
SMALL
ENHE

❓ AC2: Test with sidebar closed

LARGE
ENHE
NOTE: The HE banner does not contain a "Maybe Later" link. See below.
SMALL
ENHE

❌ AC3: Test on at least one special page
No banners appear at all.

LARGE
ENHE
SMALL
ENHE

Thanks @Edtadros and @ovasileva ! In terms of functionality it looks fine to me.

There are some expected design issues especially with the banner taking up more vertical space at higher resolutions. Myself and the fundraising team are going to work on some iterations that try to reduce this.

Thanks @Edtadros and @ovasileva ! In terms of functionality it looks fine to me.

There are some expected design issues especially with the banner taking up more vertical space at higher resolutions. Myself and the fundraising team are going to work on some iterations that try to reduce this.

Great - let us know if there's anything else we can help with! Resolving this task for now.