QA fundraising banners with new header and collapsible sidebar
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ovasileva
	Mar 10 2020, 4:43 PM

Description

Background

As a part of the desktop improvements project, we would like to ensure that the changes we are making do not affect the way that central notice and other fundraising banners appear on the page. This task is to QA the banners along with the first two changes we are making.

Acceptance criteria

copy over the fundraising banners to the beta cluster
QA banners along with collapsible sidebar and new header
QA steps:
Go to enwiki beta cluster and append ?banner=fundraising_dsk_lg&country=GB to banner
Test with sidebar open/closed
Test on at least one special page
Repeat the above with url ?banner=fundraising_dsk_sm&country=GB
Repeat steps 1-4 on hewiki beta cluster

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T16501 A way to hide the sidebar providing a "fullscreen" view
Resolved	ovasileva	T247032 [EPIC] Build collapsible sidebar and deploy to all test wikis
Resolved	ovasileva	T247323 QA fundraising banners with new header and collapsible sidebar

Event Timeline

ovasileva created this task.Mar 10 2020, 4:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2020, 4:43 PM

Putting in triaged but future until work on the sidebar is completed.

• TSkaff subscribed.Mar 10 2020, 7:00 PM

I copied our current desktop banners over to beta cluster (large, small) along with English, French and Hebrew translations. They can be viewed by adding ?banner=fundraising_dsk_lg or ?banner=fundraising_dsk_sm to the URL on any beta site.

Unfortunately there doesn't appear to be a French Wikipedia on the beta cluster to test with. There is a Hebrew Wikipedia, I imported the Albert Einstein article to give something to test with:

It doesn't look like there's any desktop improvements changes on the beta cluster yet, let me know when there are if you want any help testing!

• jbolorinos-ctr subscribed.Mar 20 2020, 4:33 PM

ovasileva moved this task from Incoming to Q4 2020 on the Vector 2022 board.Mar 30 2020, 12:18 PM

Jdlrobson assigned this task to Edtadros.Apr 17 2020, 6:58 PM

Jdlrobson moved this task from Triaged but Future to QA Tasks / Needs Reproduction on the Web-Team-Backlog-Archived board.

ovasileva edited parent tasks, added: T247032: [EPIC] Build collapsible sidebar and deploy to all test wikis; removed: T240856: [EPIC] New header for desktop improvements project.Apr 28 2020, 2:38 PM

ovasileva edited projects, added Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed Web-Team-Backlog-Archived.Jul 13 2020, 3:19 PM

ovasileva moved this task from Needs Analysis to QA on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.

ovasileva updated the task description. (Show Details)Jul 13 2020, 5:46 PM

ovasileva mentioned this in T257909: Pre and post deployment QA for sidebar & max width deployment .Jul 14 2020, 11:31 AM

@ovasileva, here's what I'm seeing. I have a pass next to the Large Banner cases, but they have odd looking links like this:

QA steps:
❓ AC1: Go to enwiki and hewiki beta cluster and append ?banner=fundraising_dsk_lg&country=GB to banner with sidebar expanded

✅ EN	✅ HE
LARGE

NOTE: The HE banner does not contain a "Maybe Later" link. See below.

✅ EN	❓ HE
SMALL

❓ AC2: Test with sidebar closed

✅ EN	✅ HE
LARGE

NOTE: The HE banner does not contain a "Maybe Later" link. See below.

✅ EN	❓ HE
SMALL

❌ AC3: Test on at least one special page
No banners appear at all.

EN	HE
LARGE

EN	HE
SMALL

Thanks @Edtadros and @ovasileva ! In terms of functionality it looks fine to me.

The messed up footer links were simply my fault for forgetting to import those translations to beta. They should be fixed now
The Maybe Later link is intentionally hidden in Hebrew
CentralNotice doesn't load on Special pages, this is expected and true on production too e.g. https://en.wikipedia.org/wiki/Special:SpecialPages?banner=B1920_0315_mlWW_dsk_p1_lg_template&country=GB

There are some expected design issues especially with the banner taking up more vertical space at higher resolutions. Myself and the fundraising team are going to work on some iterations that try to reduce this.

ovasileva moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (Kanbanana-FY-2020-21) board.Jul 15 2020, 4:23 PM

In T247323#6305424, @Pcoombe wrote:

Thanks @Edtadros and @ovasileva ! In terms of functionality it looks fine to me.

The messed up footer links were simply my fault for forgetting to import those translations to beta. They should be fixed now

The Maybe Later link is intentionally hidden in Hebrew

CentralNotice doesn't load on Special pages, this is expected and true on production too e.g. https://en.wikipedia.org/wiki/Special:SpecialPages?banner=B1920_0315_mlWW_dsk_p1_lg_template&country=GB

There are some expected design issues especially with the banner taking up more vertical space at higher resolutions. Myself and the fundraising team are going to work on some iterations that try to reduce this.

Great - let us know if there's anything else we can help with! Resolving this task for now.

	F31935121: Screen Shot 2020-07-14 at 7.47.59 AM.png
	Jul 14 2020, 3:12 PM

	F31935113: Screen Shot 2020-07-14 at 7.38.46 AM.png
	Jul 14 2020, 3:12 PM

	F31935114: Screen Shot 2020-07-14 at 7.38.35 AM.png
	Jul 14 2020, 3:12 PM

	F31935211: Screen Shot 2020-07-14 at 8.02.05 AM.png
	Jul 14 2020, 3:12 PM

	F31935203: Screen Shot 2020-07-14 at 8.07.28 AM.png
	Jul 14 2020, 3:12 PM

	F31935115: Screen Shot 2020-07-14 at 7.39.04 AM.png
	Jul 14 2020, 3:12 PM

	F31935131: Screen Shot 2020-07-14 at 7.51.15 AM.png
	Jul 14 2020, 3:12 PM

	F31935112: Screen Shot 2020-07-14 at 7.39.15 AM.png
	Jul 14 2020, 3:12 PM

QA fundraising banners with new header and collapsible sidebarClosed, ResolvedPublicActions