Parsoid psr-4 warning in composer 1.10
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 10 2020, 8:52 PM

Description

Using composer 1.10

Deprecation Notice: Class Wikimedia\Parsoid\DataParsoid located in ./wikimedia/parsoid/src/placeholder/DataParsoid.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:185

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move DataParsoid.php to .phan/stubs	mediawiki/services/parsoid	master	+1 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T247360 Avoid warnings in mediawiki/vendor.git with composer 1.10
		Resolved		cscott	T247353 Parsoid psr-4 warning in composer 1.10

Event Timeline

Reedy created this task.Mar 10 2020, 8:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2020, 8:52 PM

Reedy renamed this task from Parsoid warning in composer 1.10 to Parsoid psr-4 warning in composer 1.10.Mar 10 2020, 8:55 PM

That's fine, it's just used for phan. But phan has a different mechanism for placeholders; we should be using that instead of abusing the psr-4 path.

I guess in this case it's because the path doesn't match the namespace heirarchy

https://github.com/composer/composer/blob/8fd70d2dc4fc8f80794dbb1ca6f8c3e75173fe44/src/Composer/Autoload/ClassMapGenerator.php#L143-L196

@Reedy: It should live in .phan/stubs; hang on, patch incoming.

Change 578608 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Move DataParsoid.php to .phan/stubs

https://gerrit.wikimedia.org/r/578608

gerritbot added a project: Patch-For-Review.Mar 10 2020, 9:26 PM

Change 578608 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move DataParsoid.php to .phan/stubs

https://gerrit.wikimedia.org/r/578608

Jdforrester-WMF added a parent task: T247360: Avoid warnings in mediawiki/vendor.git with composer 1.10.Mar 10 2020, 9:58 PM

Reedy closed this task as Resolved.Mar 10 2020, 11:16 PM

Reedy assigned this task to cscott.