From T238809
As soon as a valid username or IP address is entered or the user picks a suggestion from the auto-complete suggester, the result set re-computes to exclude the user/IP as a target.
From T238809
As soon as a valid username or IP address is entered or the user picks a suggestion from the auto-complete suggester, the result set re-computes to exclude the user/IP as a target.
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Declined | None | T247356 Auto submit filters form on Special:Investigate when multiselect input changes | |||
Resolved | dbarratt | T238809 CU 2.0: Filters in the Compare tab |
@dbarratt Are there any technical challenges to doing this as auto-submit? If so we can explore other design options too.
@Niharika I think the main problem would be if the check user wanted to enter multiple targets to filter out, since a query would be performed after each user entered.
As @Tchanders pointed out, I think it would be rather jarring to select an option, and then have the page refresh (and I suppose the filter form would collapse?).
To make a smoother experience, we could render the table with JavaScript, but that's a pretty big change from what we have now. It would involve building an API to get the data. This isn't a huge lift, but it seemed like a lot if all it was for was this feature.
We could also give the user a submit button for the filters rather than the auto-submit. @Prtksxna What do you think?
This would be ideal, especially once we have filtering from the rows (T240530). The page refresh would be too jarring in those cases.
Could we auto-submit once the field loses focus? Also can we remember if the filters form was open and keep it open even after the refresh?
Yes. Although the user may not realize that they need to click outside of the form field in order for it to activate (refresh the page). Perhaps we could also provide a submit button?
Also can we remember if the filters form was open and keep it open even after the refresh?
Sure!
I am feeling a bit conflicted about this. I wanted the filtering action to feel snappy but with the full page refresh I don't think that'll happen at the moment. Auto-submitting on blur makes the interaction slightly faster, but confusing too.
I think we can keep just the Submit button for now and no auto-submit at all as it might be more jarring than useful.