Page MenuHomePhabricator

[wmf.22] Suggested edits: Issues with canceling filter - 'Cannot read property 'tasktype' of undefined`'
Closed, ResolvedPublicBUG REPORT

Description

The issue is reproducible in betalabs too.

Steps to Reproduce:

  1. On Homepage Suggested Edits module click on the arrow to navigate to the next article (doesn't matter what filters are selected), so the counter will show something like '2 of 200 suggestions'.
  2. Click on the topic filters (it's ok if it shows 'Select interests') - in the open overlay do not select any filters but click to cancel (on the 'X').
  3. The previously fully displayed article card starts displaying the skeleton which never finishing loading.
  4. Click on the navigation arrow to go to the previous article - the following error will be displayed:

Uncaught TypeError: Cannot read property 'tasktype' of undefined

explanationwidget
SuggestedEditsModule.prototype.updateTaskExplanationWidget = function() {
                    var explanationSelector = '.suggested-edits-task-explanation'
                      , $explanationElement = $(explanationSelector);
                    if (this.queuePosition < this.taskQueue.length) {
                        $explanationElement.html(new TaskExplanationWidget({
                            taskType: this.taskQueue[this.queuePosition].tasktype,
                            mode: this.mode
                        },this.logger).$element);
                        $explanationElement.toggle(true);
                    } else {
                        $explanationElement.toggle(false);
                    }
                }
                ;

The counter will show '0 of 200 suggestions'

The animated gif shows never ending card info loading (the skeleton) after canceling filter overlay

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 579443 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] TopicFiltersDialog: Actually prevent superfluous 'search' events

https://gerrit.wikimedia.org/r/579443

Change 579443 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] TopicFiltersDialog: Actually prevent superfluous 'search' events

https://gerrit.wikimedia.org/r/579443