Page MenuHomePhabricator
Create Task
Maniphest T247380

Super wide desktop small banner on 1900x1200 resolution in IE 11
Closed, ResolvedPublic
Actions

Description

Summary:
It was noticed during testing today that the Desktop Small banner covers the entire top section of the page on 1900x1200 resolution screens.

image.png (1×1 px, 224 KB)

Steps to Reproduce:

  1. Open https://en.wikipedia.org/wiki/NASA?banner=B1920_0301_mlWW_dsk_p2_sm_cnt&country=AT on a computer running IE 11 with 1920x1200 resolution
  2. Observe super wide banner

Actual Results:
Banner is super wide and covers entire top of screen on IE 11 with 1920x1200 resolution

Expected Results:
The desktop small banner should load on IE 11 with 1920x1200 resolution the same way it loads on other browsers with 1920x1200 resolution

Related Objects

Event Timeline

• jbolorinos-ctr created this task.Mar 11 2020, 2:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2020, 2:27 AM
• jbolorinos-ctr triaged this task as High priority.Mar 11 2020, 2:28 AM

Setting priority to P2 since this is issue is affecting all desktop small banners, and should be fixed before the upcoming Big Bundle campaign if possible.

• jbolorinos-ctr added a comment.Mar 11 2020, 2:30 AM

Please disregard the mention...I simply meant to abbreviate Priority 2, this task is unrelated to mentioned task

Pcoombe moved this task from Backlog to Browser specific on the Wikimedia-Fundraising-Banners board.Mar 11 2020, 12:24 PM
spatton lowered the priority of this task from High to Medium.Mar 11 2020, 1:15 PM
spatton subscribed.

I'm lowering the priority on this to Medium, as it doesn't prevent reader interaction with the banner or break the donor flow.

This is an issue we noticed in the past - IE 11 ignores media queries (in this case, ours which floats dsk sm left above 1390px) on page load. Resizing the browser triggers the media query.

• jbolorinos-ctr added a comment.Mar 11 2020, 4:21 PM

Thanks Sam, yeah I think that makes sense, this is more of an edge case since users with higher resolution browsers are less likely to use IE 11

• jbolorinos-ctr renamed this task from Super wide desktop small banner to Super wide desktop small banner on 1900x1200 resolution in IE 11.Mar 16 2020, 6:09 PM
spatton raised the priority of this task from Medium to Needs Triage.Mar 18 2020, 4:19 PM
spatton triaged this task as Medium priority.
• jbolorinos-ctr lowered the priority of this task from Medium to Low.Mar 18 2020, 4:39 PM

Updating priority to Low

Pcoombe merged a task: T255067: [Dsk Sm] Not so small Desktop Small banner on IE 11.Jun 11 2020, 10:55 AM
• jbolorinos-ctr mentioned this in T256903: 2020-07-08 en6C pre-test: desktop small batch.Jul 7 2020, 3:55 AM
• jbolorinos-ctr mentioned this in T259920: 2020-08-12 en6C pre-test: desktop small batch.Aug 11 2020, 5:26 PM
• jbolorinos-ctr mentioned this in T260848: 2020-08-20 en6C pre-test: desktop small batch.Aug 20 2020, 3:22 PM
Pcoombe closed this task as Resolved.Jan 27 2021, 12:13 PM
Pcoombe claimed this task.
Pcoombe subscribed.

This was a problem with the "in-article" banners. Not an issue with current best: https://en.wikipedia.org/wiki/Wikipedia?banner=B2021_0101_en6C_dsk_p2_sm_template&country=US

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL