Limit input length in Speechoid requests
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

To avoid overloading Speechoid, add an option to limit input. The easiest way to do this is probably just a max length for the input string.

Details

	Subject	Repo	Branch	Lines +/-
	Limit input length in Speechoid requests	mediawiki/extensions/Wikispeech	master	+70 -5

Customize query in gerrit

Related Objects

Mentioned In: rEWIS8f06ba46cd3e: Limit input length in Speechoid requests
T255497: wgConfigRegistry not overriding default configuration in PhpUnit
Mentioned Here: T248162: Use revision and segment ID as input for synthesizing speech

Event Timeline

Sebastian_Berlin-WMSE created this task.Mar 11 2020, 9:37 AM

Need to have a think about how the user becomes aware of the error.

Lokal_Profil moved this task from Incoming to Backlog on the Wikispeech-Jobrunner board.Mar 11 2020, 12:53 PM

Sebastian_Berlin-WMSE set the point value for this task to 4.Apr 16 2020, 10:18 AM

Sebastian_Berlin-WMSE moved this task from Backlog to Sprint on the Wikispeech-Jobrunner board.

Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.

kalle claimed this task.Apr 17 2020, 4:22 PM

kalle moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.

kalle added a project: User-kalle.

kalle moved this task from 🥴 Backlog to 🤠 This week on the User-kalle board.

What's a good default limit? I'm setting the config to 280 characters, e.g. what you can fit in a Tweet.

Change 591051 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Limit input length in Speechoid requests

https://gerrit.wikimedia.org/r/591051

gerritbot added a project: Patch-For-Review.Apr 20 2020, 1:45 PM

kalle moved this task from 🤠 This week to 😘 Review on the User-kalle board.Apr 20 2020, 2:09 PM

Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.Apr 24 2020, 1:56 PM

Sebastian_Berlin-WMSE moved this task from Backlog to Reviewing on the User-Sebastian_Berlin-WMSE board.

Increase from 280 to perhaps 2048?

kalle moved this task from 😘 Review to 🤔 Awaits action on the User-kalle board.May 6 2020, 9:27 AM

kalle moved this task from 🤔 Awaits action to 😘 Review on the User-kalle board.May 10 2020, 10:19 PM

kalle moved this task from 😘 Review to 🤠 This week on the User-kalle board.

kalle moved this task from 🤠 This week to 🤔 Awaits action on the User-kalle board.May 12 2020, 9:51 AM

Lokal_Profil changed the point value for this task from 4 to 2.May 14 2020, 8:40 AM

We should get this merged before T248162: Use revision and segment ID as input for synthesizing speech

Lokal_Profil mentioned this in T255497: wgConfigRegistry not overriding default configuration in PhpUnit.Jun 16 2020, 8:39 AM

Change 591051 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Limit input length in Speechoid requests

https://gerrit.wikimedia.org/r/591051

kalle mentioned this in rEWIS8f06ba46cd3e: Limit input length in Speechoid requests.Jun 23 2020, 7:03 AM

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2020, 7:10 AM

kalle moved this task from 🤔 Awaits action to 🤯 Done on the User-kalle board.Jun 23 2020, 7:55 AM

kalle moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Jun 23 2020, 8:00 AM

Sebastian_Berlin-WMSE moved this task from Reviewing to Done on the User-Sebastian_Berlin-WMSE board.Jun 23 2020, 8:12 AM

Sebastian_Berlin-WMSE closed this task as Resolved.Jun 25 2020, 11:10 AM

Limit input length in Speechoid requestsClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Limit input length in Speechoid requests
Closed, ResolvedPublic2 Estimated Story Points
Actions