Page MenuHomePhabricator

The user text field on Special:EmailUser should be required
Closed, ResolvedPublic

Description

The HTMLUserTextField on Special:EmailUser has the config required = false.

That means it's possible to submit the empty field, but it fails validation (because it also has exists = true), and the following error is shown:

Instead, it should have required = true, so that a more helpful error is shown on attempting to submit the empty field:

(It should still have exists = true for when it is submitted with a non-empty value.)

Event Timeline

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptMar 11 2020, 5:49 PM

Change 579012 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] SpecialEmailUser: Set user text field to required

https://gerrit.wikimedia.org/r/579012

Change 579012 merged by jenkins-bot:
[mediawiki/core@master] SpecialEmailUser: Set user text field to required

https://gerrit.wikimedia.org/r/579012

DannyS712 closed this task as Resolved.Mar 11 2020, 8:40 PM
DannyS712 removed a project: Patch-For-Review.