Edit comment text is missing from "setpreference" actions in Jade
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Halfak
	Mar 11 2020, 8:33 PM

Description

The edit comment for "setpreference" provided by the user via the UI doesn't appear in the edit summary on the history page. It must be getting dropped somewhere.

Details

	Subject	Repo	Branch	Lines +/-
	Add comments to SetPreference api module	mediawiki/extensions/Jade	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kevinbazira	T247897 Address UI issues identified in user-testing
		Resolved		• ACraze	T247456 Edit comment text is missing from "setpreference" actions in Jade

Event Timeline

Halfak created this task.Mar 11 2020, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2020, 8:33 PM

Chtnnh subscribed.Mar 11 2020, 8:53 PM

Halfak added a parent task: T247897: Address UI issues identified in user-testing.Mar 17 2020, 7:56 PM

• ACraze claimed this task.Mar 23 2020, 9:33 PM

• ACraze edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.

Change 582929 had a related patch set uploaded (by Accraze; owner: Accraze):
[mediawiki/extensions/Jade@master] Add comments to SetPreference api module

https://gerrit.wikimedia.org/r/582929

gerritbot added a project: Patch-For-Review.Mar 23 2020, 10:14 PM

Looks like the SetPreference api module was missing the comments param. I fixed that and also exposed the comment in the revision history in the above patchset.

• ACraze moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.Mar 23 2020, 10:21 PM

Change 582929 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Add comments to SetPreference api module

https://gerrit.wikimedia.org/r/582929

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 24 2020, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2020, 5:20 AM