Page MenuHomePhabricator
Create Task
Maniphest T247462

Add a confirmation dialog to Jade
Closed, ResolvedPublic
Actions

Description

When a user performs an action, we want to give them a confirmation so that they know that something happened.

This needs some design work. What should the confirmation dialog look like?

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Halfak created this task.Mar 11 2020, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2020, 9:04 PM
Chtnnh subscribed.Mar 12 2020, 9:42 AM
Halfak added a parent task: T247897: Address UI issues identified in user-testing.Mar 17 2020, 7:44 PM
Halfak updated the task description. (Show Details)Mar 18 2020, 1:37 PM
Halfak added a comment.Mar 18 2020, 1:39 PM

Maybe something like:

"You have successfully <action>"

Actions:

  • "proposed a label"
  • "endorsed a label"
  • "deleted a proposal"
  • "endorsed a proposal"
Halfak triaged this task as Low priority.Mar 24 2020, 5:12 PM
Halfak moved this task from Unsorted to New development on the Machine-Learning-Team board.
kevinbazira claimed this task.Apr 2 2020, 3:02 PM
kevinbazira subscribed.

@Halfak I have ended up using the MW bubble notification to give users feedback/confirmation that their action was successful.

gerritbot added a comment.Apr 2 2020, 3:03 PM

Change 585515 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW bubble notification for jade-updateproposal

https://gerrit.wikimedia.org/r/585515

gerritbot added a project: Patch-For-Review.Apr 2 2020, 3:03 PM
kevinbazira edited projects, added Machine-Learning-Team (Active Tasks); removed Machine-Learning-Team.Apr 2 2020, 3:44 PM
kevinbazira moved this task from Parked to Review on the Machine-Learning-Team (Active Tasks) board.
gerritbot added a comment.Apr 2 2020, 9:27 PM

Change 585515 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW bubble notification for jade-updateproposal

https://gerrit.wikimedia.org/r/585515

• ACraze subscribed.Apr 2 2020, 9:56 PM

Great work on this so far @kevinbazira, this approach works well with jade-updateproposal, just tested it on beta. I think it should work for all the other api modules too

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 2 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2020, 10:11 PM
kevinbazira added a comment.Apr 3 2020, 6:44 AM

Thanks @ACraze, I am going to implement it for for all the other api modules too.

gerritbot added a comment.Apr 3 2020, 6:46 AM

Change 585676 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Fixed Jade bubble notification reload bug

https://gerrit.wikimedia.org/r/585676

gerritbot added a project: Patch-For-Review.Apr 3 2020, 6:46 AM
gerritbot added a comment.Apr 3 2020, 7:23 AM

Change 585683 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-updateendorsement

https://gerrit.wikimedia.org/r/585683

gerritbot added a comment.Apr 3 2020, 5:52 PM

Change 585676 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Fixed Jade bubble notification reload bug

https://gerrit.wikimedia.org/r/585676

gerritbot added a comment.Apr 3 2020, 5:53 PM

Change 585683 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-updateendorsement

https://gerrit.wikimedia.org/r/585683

Maintenance_bot removed a project: Patch-For-Review.Apr 3 2020, 6:10 PM
gerritbot added a comment.Apr 6 2020, 5:30 AM

Change 586163 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-deleteendorsement

https://gerrit.wikimedia.org/r/586163

gerritbot added a project: Patch-For-Review.Apr 6 2020, 5:30 AM
gerritbot added a comment.Apr 6 2020, 5:41 AM

Change 586164 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-deleteproposal

https://gerrit.wikimedia.org/r/586164

gerritbot added a comment.Apr 6 2020, 6:43 PM

Change 586163 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-deleteendorsement

https://gerrit.wikimedia.org/r/586163

gerritbot added a comment.Apr 6 2020, 6:43 PM

Change 586164 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-deleteproposal

https://gerrit.wikimedia.org/r/586164

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2020, 7:11 PM
gerritbot added a comment.Apr 7 2020, 5:53 AM

Change 586492 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-endorse

https://gerrit.wikimedia.org/r/586492

gerritbot added a project: Patch-For-Review.Apr 7 2020, 5:53 AM
gerritbot added a comment.Apr 7 2020, 6:21 AM

Change 586493 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-createandendorse

https://gerrit.wikimedia.org/r/586493

gerritbot added a comment.Apr 7 2020, 6:19 PM

Change 586492 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-endorse

https://gerrit.wikimedia.org/r/586492

gerritbot added a comment.Apr 7 2020, 6:19 PM

Change 586493 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-createandendorse

https://gerrit.wikimedia.org/r/586493

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.28; 2020-04-14); removed MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 7 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 7 2020, 7:10 PM
gerritbot added a comment.Apr 8 2020, 6:02 AM

Change 587401 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-setpreference

https://gerrit.wikimedia.org/r/587401

gerritbot added a project: Patch-For-Review.Apr 8 2020, 6:02 AM
gerritbot added a comment.Apr 8 2020, 6:18 AM

Change 587404 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-moveendorsement

https://gerrit.wikimedia.org/r/587404

gerritbot added a comment.Apr 9 2020, 6:57 AM

Change 587687 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Remove "successfully" from translation messages

https://gerrit.wikimedia.org/r/587687

gerritbot added a comment.Apr 9 2020, 7:07 AM

Change 587690 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-setpreference

https://gerrit.wikimedia.org/r/587690

gerritbot added a comment.Apr 9 2020, 7:12 AM

Change 587401 abandoned by Kevin Bazira:
Added MW message key for jade-setpreference

Reason:
This has been fixed with: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Jade/ /587690

https://gerrit.wikimedia.org/r/587401

gerritbot added a comment.Apr 9 2020, 7:23 AM

Change 587693 had a related patch set uploaded (by Kevin Bazira; owner: Kevin Bazira):
[mediawiki/extensions/Jade@master] Added MW message key for jade-moveendorsement

https://gerrit.wikimedia.org/r/587693

gerritbot added a comment.Apr 9 2020, 7:51 AM

Change 587404 abandoned by Kevin Bazira:
Added MW message key for jade-moveendorsement

Reason:
This has been fixed with: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Jade/ /587693

https://gerrit.wikimedia.org/r/587404

gerritbot added a comment.Apr 9 2020, 6:44 PM

Change 587687 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove "successfully" from translation messages

https://gerrit.wikimedia.org/r/587687

gerritbot added a comment.Apr 9 2020, 6:44 PM

Change 587690 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-setpreference

https://gerrit.wikimedia.org/r/587690

gerritbot added a comment.Apr 9 2020, 6:48 PM

Change 587693 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Added MW message key for jade-moveendorsement

https://gerrit.wikimedia.org/r/587693

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 7:10 PM
Halfak moved this task from Review to Completed on the Machine-Learning-Team (Active Tasks) board.Apr 13 2020, 4:48 PM
Halfak closed this task as Resolved.Jun 22 2020, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits