Page MenuHomePhabricator

Audit all ->delete calls
Closed, ResolvedPublic

Description

To find LocalFile::delete

Event Timeline

DannyS712 created this task.

https://codesearch.wmflabs.org/search/?q=-%3Edelete%5C(&i=nope&files=&repos=
Just going to list repos that use LocalFile::delete

  • Core - FileDeleteForm::doDelete
  • Core - SpecialMovepage::doSubmit (maybe, need to trace)
  • Core - deleteBatch::execute (maybe, need to trace)
  • WebDAV - WebDAVFileFile::delete (maybe, need to trace)
  • DeleteBatch - DeleteBatchForm::deletePage
  • FileImporter - ImporterTest::tearDown
  • GraphViz - GraphViz::deleteArticleUploadedFiles, ::deleteFiles (maybe, need to trace)

Looked through that entire codesearch

Also, extended by:

  • ForeignDBFile
  • OldLocalFile
  • NSFileRepo's NSLocalFile
  • NSFileRepo's NSOldLocalFile (via OldLocalFile)
  • GraphViz's UploadLocalFile

Haven't found any more