| Tchanders | |
| Mar 12 2020, 2:20 PM |
| F31698948: switch_to_investigate_form.png | |
| Mar 23 2020, 1:34 PM |
| F31667313: image.png | |
| Mar 12 2020, 2:20 PM |
This task is for creating links between Special:Investigate and Special:InvestigateLog. Acceptance criteria:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add page links and subtitle to Special:Investigate | mediawiki/extensions/CheckUser | master | +66 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dreamy_Jazz | T247789 Abstract SpecialCheckUser::addLogEntry() | |||
| Resolved | Tchanders | T245662 CU 2.0: Logging for Special:Investigate - Adding the data | |||
| Resolved | dmaza | T247516 CU 2.0: Logging for Special:Investigate - Page links |
Change 579454 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] [WIP] Add page links and subtitle to Special:Investigate
@Prtksxna Are we likely to add a help link to this page, and if so, does that affect these buttons? (Help links are added top right)
Oh yeah, that is something to consider, thanks for pointing it out. This page probably would need a help link eventually. I am working on some changes to the layout of the header section and will get back to this once that is done.
Should the button be in title case? i.e. "New Investigation" instead of "New investigation" ? I expected the former, but the screenshot has the latter.
Oh, thanks for bringing this up. I always thought we do sentence case for buttons too (see Special:Preferences). Do you know of places where we are using title? I'll ask other designers too.
Not that I can think of now that I can think of it. It felt like an incomplete sentence so I assumed it was a title. 🤷♂️
Change 579454 had a related patch set uploaded (by Tchanders; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Add page links and subtitle to Special:Investigate
Change 579454 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add page links and subtitle to Special:Investigate
- There is a button on the right side of the Special:Investigate header to access the logs - Logs
True.
- That leads to Special:InvestigateLog
True.
- There is a link under the page title to go back to the main form - Switch to Investigate form
Looks like:
Link goes to Special:Investigate (rather than back to the current investigation).
Link goes to Special:Investigate (rather than back to the current investigation).
Hmm, that's a good catch @dom_walden. I am unsure what the desired outcome should be if there is an ongoing investigation. I suspect users would not switch over to the logs in the middle of an investigation.
Let's roll with this and rethink if we hear otherwise.