Page MenuHomePhabricator

Lexeme: Use "vue" ResourceLoader module from core
Closed, ResolvedPublic

Description

vue was introduced into core as ResourceLoader module - we should depend (e.g.) on it instead of the (now redundant) wikibase equivalent.

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 12 2020, 2:27 PM
Pablo-WMDE renamed this task from Use "vue" ResourceLoader module from core to Lexeme: Use "vue" ResourceLoader module from core.Mar 12 2020, 2:42 PM

Change 578354 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Use vue ResourceLoader module from MediaWiki core

https://gerrit.wikimedia.org/r/578354

The above Gerrit change doesn’t work yet, though I haven’t been able to figure out why – it seems to be something related to Vuex registration.

Incidentally, there is a Gerrit change to add Vuex as a ResourceLoader module to core (albeit a completely different version). Maybe it’s possible to use both Vue and Vuex from core, and avoid whatever problem currently plagues the above change? (This is a wild guess.)

Hi,

I have not forgotten that you - more or less - handed this to me.
My hypothesis is that I was a bit too optimistic in https://gerrit.wikimedia.org/r/522100 the way vuex is still expected to come from global while vue (tries to) not do that anymore. You can make it green by undoing the change it did to tests/jasmine/helpers/vue.js but I'd prefer we took the time to actually make sure that the production code DI is fine, not just cook the tests.
I'm still happy to do this, it's just a matter of priorities (and Lexeme is notoriously at the bottom of the list).

I have not forgotten that you - more or less - handed this to me.

For what it’s worth, my impression was more that I tried to make this work and gave up, then you tried and didn’t succeed either, and now it’s back in the backlog for anyone to work on. I certainly don’t consider you responsible for it, but if you want to keep going (eventually, depending on priorities), that’s great.

Okay, I finally found a solution (and took https://gerrit.wikimedia.org/r/578354 out of WIP).

Change 578354 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Use vue+vuex ResourceLoader modules from MediaWiki core

https://gerrit.wikimedia.org/r/578354

Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 15 2020, 9:26 AM
Lucas_Werkmeister_WMDE claimed this task.