Page MenuHomePhabricator

Bridge: Use "vue" ResourceLoader module from core
Closed, ResolvedPublic

Description

vue was introduced into core as ResourceLoader module - we should depend (e.g.) on it instead of the (now redundant) wikibase equivalent.

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 12 2020, 2:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Pablo-WMDE renamed this task from Use "vue" ResourceLoader module from core to Bridge: Use "vue" ResourceLoader module from core.Mar 12 2020, 2:42 PM

Change 579292 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: depend on 'vue' ResourceLoader module from core

https://gerrit.wikimedia.org/r/579292

Change 579292 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: depend on 'vue' ResourceLoader module from core

https://gerrit.wikimedia.org/r/579292

Unfortunately, the vuejs dev-tools still don't seem to work with debug=true appended to the url. I guess the reason is that "our" code is still compiled for production?

Unfortunately, the vuejs dev-tools still don't seem to work with debug=true appended to the url

Yes, I consider this a challenge tracked in T228857: Step 1: minification of common.js (formerly: Investigate common.js bundle content/size) though (also see T246456: Performance review of Wikidata Bridge's "potential optimisations that haven't been performed yet").

Michael closed this task as Resolved.Mar 13 2020, 11:15 AM
Michael moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-16 board.

Unfortunately, the vuejs dev-tools still don't seem to work with debug=true appended to the url

Yes, I consider this a challenge tracked in T228857: Step 1: minification of common.js (formerly: Investigate common.js bundle content/size) though (also see T246456: Performance review of Wikidata Bridge's "potential optimisations that haven't been performed yet").

I don't see how "enable dev-tools when debug=true" is an AC in those tickets. That being said, it is not an AC for this task either, therefore this task can be resolved.