Page MenuHomePhabricator
Create Task
Maniphest T247520

Use "vue" ResourceLoader module from core
Closed, ResolvedPublic
Actions

Description

Once the subtasks are done, the vue2 ResourceLoader module should be removed from wikibase.
see.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+0 -31Remove vue2 ResourceLoader module from wikibase
mediawiki/extensions/Wikibasemaster+8 -8Move vue2 ResourceLoader module from Lib to View
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pablo-WMDE created this task.Mar 12 2020, 2:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2020, 2:41 PM
Pablo-WMDE added subtasks: T247519: Bridge: Use "vue" ResourceLoader module from core, T247518: Lexeme: Use "vue" ResourceLoader module from core, T228528: Termbox: Use "vue" ResourceLoader module from core.Mar 12 2020, 2:42 PM
Pablo-WMDE updated the task description. (Show Details)Mar 12 2020, 2:51 PM
Lucas_Werkmeister_WMDE merged a task: T245733: Remove duplicate Vue ResourceLoader module from Wikibase.Mar 12 2020, 4:17 PM
Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.
Michael closed subtask T247519: Bridge: Use "vue" ResourceLoader module from core as Resolved.Mar 13 2020, 11:15 AM
WMDE-leszek added a subscriber: WMDE-leszek.Apr 1 2020, 11:43 AM
Addshore added a project: Wikidata-Campsite.Apr 1 2020, 11:52 AM
Addshore added a subscriber: Addshore.
Lucas_Werkmeister_WMDE mentioned this in T250263: Use "vuex" ResourceLoader module from core.Apr 15 2020, 11:54 AM
Lucas_Werkmeister_WMDE mentioned this in T255115: Investigate coupling of ResourceLoader modules used in both places.Jun 12 2020, 9:48 AM
Lucas_Werkmeister_WMDE closed subtask T247518: Lexeme: Use "vue" ResourceLoader module from core as Resolved.Jun 15 2020, 9:26 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jun 15 2020, 1:46 PM

Change 605593 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Move vue2 ResourceLoader module from Lib to View

https://gerrit.wikimedia.org/r/605593

gerritbot added a project: Patch-For-Review.Jun 15 2020, 1:46 PM
gerritbot added a comment.Jun 15 2020, 4:21 PM

Change 605593 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move vue2 ResourceLoader module from Lib to View

https://gerrit.wikimedia.org/r/605593

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 15 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 5:10 PM
guergana.tzatchkova claimed this task.Jul 1 2020, 1:22 PM
Michael edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.Jul 1 2020, 2:52 PM
guergana.tzatchkova moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Jul 1 2020, 3:01 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 1 2020, 3:15 PM
guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Jul 9 2020, 1:16 PM
guergana.tzatchkova moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Jul 14 2020, 10:08 AM
gerritbot added a comment.Jul 14 2020, 10:55 AM

Change 612539 had a related patch set uploaded (by Guergana Tzatchkova; owner: Guergana Tzatchkova):
[mediawiki/extensions/Wikibase@master] vue2 ResourceLoader module removed from wikibase

https://gerrit.wikimedia.org/r/612539

gerritbot added a project: Patch-For-Review.Jul 14 2020, 10:55 AM
guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Jul 14 2020, 1:59 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Jul 14 2020, 8:33 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.Jul 15 2020, 8:44 PM
gerritbot added a comment.Jul 15 2020, 9:02 PM

Change 612539 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove vue2 ResourceLoader module from wikibase

https://gerrit.wikimedia.org/r/612539

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 9:10 PM
Michael closed subtask T228528: Termbox: Use "vue" ResourceLoader module from core as Resolved.Aug 3 2020, 11:19 AM
Michael closed subtask T247521: Tainted Ref: Use "vue" ResourceLoader module from core as Resolved.
Michael closed this task as Resolved.Aug 3 2020, 11:27 AM
Michael moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Michael added a subscriber: Michael.

The vue module has been removed from Wikibase for a while now. So if there would have been any problems, we should have noticed them by now.

What remains is adding a way to ensure that the version of the module that we are expecting, and the version that is in core remain in sync, but there is a separate and dedicated task for that: T259468: Version compare apps' externalized modules and core modules.
Also, a similar, but separate task exists for vuex: T250263: Use "vuex" ResourceLoader module from core.

Jakob_WMDE reopened subtask T228528: Termbox: Use "vue" ResourceLoader module from core as Open.Fri, Sep 18, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL