Page MenuHomePhabricator

Block succeeded - "$1" has been blocked
Open, Needs TriagePublic

Description

Seen on enwiki, 1.35.0-wmf.22

Not tested if it's a local change

Event Timeline

Reedy created this task.Mar 12 2020, 6:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2020, 6:18 PM
Reedy added a comment.Mar 12 2020, 6:20 PM

https://en.wikipedia.org/w/index.php?title=MediaWiki:Blockipsuccesstext&action=history shows no recent changes

Message in core uses $1

	"blockipsuccesstext": "[[Special:Contributions/$1|$1]] has been blocked.<br />\nSee the [[Special:BlockList|block list]] to review blocks.",
Reedy added a comment.Mar 12 2020, 6:23 PM

Works on my dev wiki though...

Cannot reproduce at testwiki. However...testwiki's Special:Unblock has this:

related?

Could not reproduce either the initial bug or Urbanecm's unblock issue on the beta cluster

..,. ingore what i said, one should not expect MediaWiki NS to be intact :-) https://test.wikipedia.org/wiki/MediaWiki:Unblockiptext explains that...

Amorymeltzer added a subscriber: Amorymeltzer.EditedMar 12 2020, 8:31 PM

@Urbanecm You're welcome!

@Reedy Where'd you see this on enwiki, I couldn't replicate it there.

@Reedy Where'd you see this on enwiki, I couldn't replicate it there.

When blocking a user?

It's pretty broken as seen in the HTML too

<div id="mw-blockipsuccesstext" class="plainlinks">"<b><a href="/wiki/User:$1" class="mw-redirect" title="User:$1">$1</a></b>" has been blocked <span class="plainlinks">(<a href="/wiki/User_talk:$1" class="mw-redirect" title="User talk:$1">talk</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=User_talk:$1&amp;action=edit">edit talk</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=User_talk:$1&amp;action=edit&amp;section=new">message</a>&nbsp;| <a href="/wiki/Special:Contributions/$1" title="Special:Contributions/$1">contribs</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=Special:AbuseLog&amp;wpSearchUser=%241">filter log</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=Special:Log&amp;type=block&amp;user=&amp;page=User:%241">block log</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/wiki/Special:BlockIP/$1">change block settings</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=User:$1&amp;action=watch">watch</a>&nbsp;| <a href="https://meta.wikimedia.org/wiki/Special:CentralAuth/$1" class="extiw" title="meta:Special:CentralAuth/$1">centralauth</a>&nbsp;| <a href="/wiki/Special:Nuke/$1" title="Special:Nuke/$1">Delete all recently contributed pages</a>)</span>.
<ul><li>See also:
<ul><li><a href="/wiki/Special:BlockList" title="Special:BlockList">List of active blocks</a></li>
<li><a href="/wiki/Special:Log/block" title="Special:Log/block">Block log</a></li>
<li><a href="/wiki/Special:Block" title="Special:Block">Add another block</a></li>
<li><a href="/wiki/Special:Log/newusers" title="Special:Log/newusers">User creation log</a></li>
<li><a href="/wiki/Wikipedia:Template_messages/User_talk_namespace#Blocks" class="mw-redirect" title="Wikipedia:Template messages/User talk namespace">Templated block messages</a></li>
<li><a class="external text" href="https://en.wikipedia.org/w/index.php?title=Wikipedia:Administrator_intervention_against_vandalism&amp;action=purge">Administrator intervention against vandalism</a></li>
<li><a class="external text" href="https://en.wikipedia.org/w/index.php?title=Wikipedia:Usernames_for_administrator_attention&amp;action=purge">Usernames for administrator attention</a></li>
<li><a class="external text" href="https://en.wikipedia.org/w/index.php?title=Category:Requests_for_unblock&amp;action=purge">Requests for unblock</a></li></ul></li></ul>
</div>

Noting testwiki is running a newer version

Tried to copy enwiki's success message to cswiki temporarily (both should be 1.35.0-wmf.22) and cannot reproduce.

Tried to copy enwiki's success message to cswiki temporarily (both should be 1.35.0-wmf.22) and cannot reproduce.

It's odd. It's not changed in a long time, and the code outputting it hasn't either...

Hmm... Is it possible there is a non-printable character between the $ and 1? What would happen if we bypass message cache temporarily?

I ask because I'm not seeing that:

Reedy added a comment.Mar 13 2020, 2:57 AM

I've seen it on two user and 1 IP block...

If it's not happening always, it reminds me of T247078, which criples random messages in an unpredicable way.

Nick added a subscriber: Nick.May 4 2020, 11:12 PM