Page MenuHomePhabricator

Administrator's "Block succeeded" confirmation page broken ("$1 has been blocked")
Closed, ResolvedPublic

Description

Seen on enwiki, 1.35.0-wmf.22

Screenshot 2020-03-12 at 18.16.32.png (652×2 px, 135 KB)

Not tested if it's a local change

Event Timeline

https://en.wikipedia.org/w/index.php?title=MediaWiki:Blockipsuccesstext&action=history shows no recent changes

Message in core uses $1

	"blockipsuccesstext": "[[Special:Contributions/$1|$1]] has been blocked.<br />\nSee the [[Special:BlockList|block list]] to review blocks.",

Works on my dev wiki though...

Screenshot 2020-03-12 at 18.22.56.png (250×536 px, 27 KB)

Cannot reproduce at testwiki. However...testwiki's Special:Unblock has this:

image.png (660×1 px, 72 KB)

related?

Could not reproduce either the initial bug or Urbanecm's unblock issue on the beta cluster

..,. ingore what i said, one should not expect MediaWiki NS to be intact :-) https://test.wikipedia.org/wiki/MediaWiki:Unblockiptext explains that...

@Urbanecm You're welcome!

@Reedy Where'd you see this on enwiki, I couldn't replicate it there.

@Reedy Where'd you see this on enwiki, I couldn't replicate it there.

When blocking a user?

Screenshot 2020-03-12 at 21.59.36.png (948×2 px, 247 KB)

It's pretty broken as seen in the HTML too

<div id="mw-blockipsuccesstext" class="plainlinks">"<b><a href="/wiki/User:$1" class="mw-redirect" title="User:$1">$1</a></b>" has been blocked <span class="plainlinks">(<a href="/wiki/User_talk:$1" class="mw-redirect" title="User talk:$1">talk</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=User_talk:$1&amp;action=edit">edit talk</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=User_talk:$1&amp;action=edit&amp;section=new">message</a>&nbsp;| <a href="/wiki/Special:Contributions/$1" title="Special:Contributions/$1">contribs</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=Special:AbuseLog&amp;wpSearchUser=%241">filter log</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=Special:Log&amp;type=block&amp;user=&amp;page=User:%241">block log</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/wiki/Special:BlockIP/$1">change block settings</a>&nbsp;| <a class="external text" href="https://en.wikipedia.org/w/index.php?title=User:$1&amp;action=watch">watch</a>&nbsp;| <a href="https://meta.wikimedia.org/wiki/Special:CentralAuth/$1" class="extiw" title="meta:Special:CentralAuth/$1">centralauth</a>&nbsp;| <a href="/wiki/Special:Nuke/$1" title="Special:Nuke/$1">Delete all recently contributed pages</a>)</span>.
<ul><li>See also:
<ul><li><a href="/wiki/Special:BlockList" title="Special:BlockList">List of active blocks</a></li>
<li><a href="/wiki/Special:Log/block" title="Special:Log/block">Block log</a></li>
<li><a href="/wiki/Special:Block" title="Special:Block">Add another block</a></li>
<li><a href="/wiki/Special:Log/newusers" title="Special:Log/newusers">User creation log</a></li>
<li><a href="/wiki/Wikipedia:Template_messages/User_talk_namespace#Blocks" class="mw-redirect" title="Wikipedia:Template messages/User talk namespace">Templated block messages</a></li>
<li><a class="external text" href="https://en.wikipedia.org/w/index.php?title=Wikipedia:Administrator_intervention_against_vandalism&amp;action=purge">Administrator intervention against vandalism</a></li>
<li><a class="external text" href="https://en.wikipedia.org/w/index.php?title=Wikipedia:Usernames_for_administrator_attention&amp;action=purge">Usernames for administrator attention</a></li>
<li><a class="external text" href="https://en.wikipedia.org/w/index.php?title=Category:Requests_for_unblock&amp;action=purge">Requests for unblock</a></li></ul></li></ul>
</div>

Noting testwiki is running a newer version

Tried to copy enwiki's success message to cswiki temporarily (both should be 1.35.0-wmf.22) and cannot reproduce.

Tried to copy enwiki's success message to cswiki temporarily (both should be 1.35.0-wmf.22) and cannot reproduce.

It's odd. It's not changed in a long time, and the code outputting it hasn't either...

Hmm... Is it possible there is a non-printable character between the $ and 1? What would happen if we bypass message cache temporarily?

I ask because I'm not seeing that:

Screen Shot 2020-03-12 at 20.45.46.png (459×1 px, 131 KB)

I've seen it on two user and 1 IP block...

If it's not happening always, it reminds me of T247078, which criples random messages in an unpredicable way.

Krinkle added a subscriber: Krinkle.

Tagging AHT as steward for Blocks. This broke a few months ago in Q1 or Q2. If you find the root cause, it's likely it may have caused T253581 as well.

Krinkle renamed this task from Block succeeded - "$1" has been blocked to Administrator's "Block succeeded" confirmation page broken ("$1 has been blocked").Dec 15 2020, 1:41 AM

@dom_walden Do you think you could try reproducing this bug?

@dom_walden Do you think you could try reproducing this bug?

I have tried a few times over the last week or so to reproduce this on test.wikipedia.org, but was not successful.

I also tried blocking myself on enwiki, which I think is what @Reedy was doing.

I even tried to reproduce T253581 as well on testwiki, again unsuccessfully.

Questions:

  • Were there were any errors in the logs associated with this bug?
  • Were there any code changes at that time which could cause this?
  • Were there any config changes which could cause this?
  • Might it matter which Cluster you are connected to? Can this be controlled when testing?

I would recommend passing this on to someone who understands the Message system and/or caching more than I do.

I'm not sure why I didn't look before... but https://en.wikipedia.org/w/index.php?title=MediaWiki:Blockipsuccesstext/en-gb&action=edit is highly suspicious

{{MediaWiki:Blockipsuccesstext}}

Has it actually been broken since 2014?

I'm not sure why I didn't look before... but https://en.wikipedia.org/w/index.php?title=MediaWiki:Blockipsuccesstext/en-gb&action=edit is highly suspicious

Ooh, I changed https://test.wikipedia.org/wiki/MediaWiki:Blockipsuccesstext/en-gb to be the same, changed my language to "en-GB", and can now reproduce on testwiki.

reprod.png (557×1 px, 72 KB)

I just deleted the message... But I guess I see the problem that they were trying to fix... So I restored it.

On https://en.wikipedia.org/wiki/MediaWiki:Blockipsuccesstext/en-gb we see what is on https://en.wikipedia.org/wiki/MediaWiki:Blockipsuccesstext/en (ie the MW default) rather than what is on https://en.wikipedia.org/wiki/MediaWiki:Blockipsuccesstext

So I guess the question is why en-gb doesn't fallback to the root page (in en)?

Is there any way to make this work, passing $1 through rather than just copy pasting the whole message?

To solve this specific issue on enwiki, you could change the en message to: {{{1|$1}}} and the en-gb message to {{MediaWiki:Blockipsuccesstext|$1}}.