Page MenuHomePhabricator

ApiQueryTags reports core tags as 'extension' for the source
Open, LowPublic

Description

Example: https://en.wikipedia.org/w/api.php?action=query&list=tags&tgprop=source&tglimit=max reports mw-rollback, mw-undo, etc as coming from core

ApiQueryTags::execute
if ( $fld_source ) {
	$tag['source'] = [];
	if ( $isSoftware ) {
		// TODO: Can we change this to 'software'?
		$tag['source'][] = 'extension';
	}
	if ( $isExplicit ) {
		$tag['source'][] = 'manual';
	}
}

Either the inline todo should be actioned, or there should be a difference between core and extension tags.
Todo was added in 951c1016e

Steps:

  • Add "software" type tag "source" entries
  • Get TWN to mass copy the messages
  • Send an api-announce deprecation email about "extension" type tag "source" entries
  • Send an api-announce removal email about"extension" type tag "source" entries
  • Remove the "extension" entries from output

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 added subscribers: TTO, Legoktm.

CC @Legoktm @TTO who added the initial todo note

Anomie subscribed.

Just changing it to "software" would be a compatibility break. We'd have to add "software" while keeping "extension", and follow the usual deprecation processes to eventually remove "extension".

Anomie removed a project: Platform Engineering.

I'm going to untag CPT since it's unlikely we'll work on this any time soon. But if someone submits patches, we'll review them.

Change 969221 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] api: add "software" tag source to take the place of "extension" in ApiQueryTags

https://gerrit.wikimedia.org/r/969221

Change 969221 merged by jenkins-bot:

[mediawiki/core@master] api: add "software" tag source to take the place of "extension" in ApiQueryTags

https://gerrit.wikimedia.org/r/969221

CC'ing @Nikerabbit . The new messages can clone the old translations. I don't know the exact TWN process for that, but it should apply here.

CC'ing @Nikerabbit . The new messages can clone the old translations. I don't know the exact TWN process for that, but it should apply here.

@aaron In case you have to move a message from one repo to another repo translatewiki scripts can move the translations to the new repo and keep the translation history. No need to duplicate the translations.

In case a message will be kept in the old repo and added with another message key in another repo we do not have a script to duplicate translations. Please add the translations in the 2nd repo.

Add me as i18n reviewer in both cases. Thanks.

CC'ing @Nikerabbit . The new messages can clone the old translations. I don't know the exact TWN process for that, but it should apply here.

@aaron In case you have to move a message from one repo to another repo translatewiki scripts can move the translations to the new repo and keep the translation history. No need to duplicate the translations.

In case a message will be kept in the old repo and added with another message key in another repo we do not have a script to duplicate translations. Please add the translations in the 2nd repo.

Add me as i18n reviewer in both cases. Thanks.

The repo isn't changing, it's just a new key that can start off with the values of an old key. The old key will get removed later.

! In T247552#9302887, @aaron wrote:

The repo isn't changing, it's just a new key that can start off with the values of an old key. The old key will get removed later.

in this case please duplicate the translations in the patch.