On https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats, the "edit source" links are huge. This looks like some important styles are not loading.
Other skins look OK (I tested MonoBook).
matmarex | |
Mar 12 2020, 9:09 PM |
F31690781: capture.png | |
Mar 19 2020, 1:07 AM |
F31690752: Screenshot 2020-03-19 at 00.45.08.png | |
Mar 19 2020, 12:45 AM |
F31690604: image.png | |
Mar 18 2020, 11:51 PM |
F31678421: image.png | |
Mar 12 2020, 9:09 PM |
On https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats, the "edit source" links are huge. This looks like some important styles are not loading.
Other skins look OK (I tested MonoBook).
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Release | hashar | T233872 1.35.0-wmf.24 deployment blockers | ||
Resolved | Jdlrobson | T247566 Broken section edit links styles on Vector |
Some time after you reported it I couldn't reproduce the issue: the "edit source" links were normal on the page you've linked.
This has somehow been unfixed and is now broken on https://test.wikipedia.org/wiki/User_talk:Matma_Rex.
I have seen this bug on my local installation when the core version is updated to 1.35.0-wmf.24 and vector version remains to 1.35.0-wmf.23.
Related probably: On office wiki, the print footer is visible on desktop, and thumbnails are no longer aligned to the side.
I'm unsure but I think the presentation is missing a .mw-editsection rule:
/* Display editsection links smaller and next to headings */ .mw-editsection, .mw-editsection-like { font-size: small; /* <-------- */ font-weight: normal; margin-left: 1em; vertical-align: baseline; /* Reset line-height; headings tend to have it set to larger values */ line-height: 1em; }
It seems to be related to a change in Core but I'm having trouble bisecting it so far.
Change 581224 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/core@master] Revert "mediawiki.legacy.shared is merged into existing skin modules and removed"
^I've taken a stab at a revert but I think there may be dependency fan out issues for the skins. It would be much, much better if a proper fix can be made instead both to minimize risk and not lose the work put in thus far. @Jdlrobson, can you take a look at this tomorrow?
Change 581238 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/Vector@master] skins.vector.styles.legacy needs to define legacy feature
I can see exactly what the issue. Revert won't help here as new HTML is already in cache.
Have taken a copy of a page with the issue here > P10727. Looks like there was a rebase issue. skins.vector.styles.legacy needs to define the "legacy" feature so no caching implications with the fix here. Above patch should take care of it ^
Change 581248 had a related patch set uploaded (by Krinkle; owner: Jdlrobson):
[mediawiki/skins/Vector@wmf/1.35.0-wmf.24] skins.vector.styles.legacy needs to define legacy feature
Change 581224 abandoned by Niedzielski:
Revert "mediawiki.legacy.shared is merged into existing skin modules and removed"
Change 581238 merged by jenkins-bot:
[mediawiki/skins/Vector@master] skins.vector.styles.legacy needs to define legacy feature
So this seems to be affecting group0 wikis and generating complaints. Patch should probably be backported and deployed rather urgently
I am the train conductor this week but I can not deploy anything in the morning (home schooling due to the virus). Anyone has my blessing to have https://gerrit.wikimedia.org/r/#/c/581248/ deployed.
I've scheduled https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/581248 for deployment during today's European mid-day SWAT window.
Change 581248 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.35.0-wmf.24] skins.vector.styles.legacy needs to define legacy feature
Mentioned in SAL (#wikimedia-operations) [2020-03-19T10:24:50Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.24/skins/Vector/skin.json: [[gerrit:581248|skins.vector.styles.legacy needs to define legacy feature (T247566)]] (duration: 01m 08s)