Page MenuHomePhabricator

Fatal errors caused in ParserFileProcessingHookHandlers for certain images during RunSingleJob.php
Closed, ResolvedPublic

Description

PHP Fatal Error from line 82 of /srv/mediawiki/php-1.35.0-wmf.22/extensions/PageImages/includes/ParserFileProcessingHookHandlers.php: Maximum execution time of 180 seconds exceeded

L73 and L82 seem to be at fault here.

https://logstash.wikimedia.org/goto/a0f8bbfc794d16817f6a7e31bfd6907a

Event Timeline

It is possible that the hook is too slow indeed. But I suspect rather it started happening because the timeout itself was accidentally lowered for the job queue. See T247622: RunSingleJob.php timeout too low at 180 seconds.

Not sure if this is causing data loss or meaning certain articles do not get page images...

We're not really sure what to do with this bug. I've opened up T252249 to try and find a better suited team to help maintain this extension as clearly we're not doing a great job.

Krinkle removed ovasileva as the assignee of this task.
Krinkle added a subscriber: ovasileva.

Not sure if this is causing data loss or meaning certain articles do not get page images...

When this hook fatals, the impact isn't so much PageImages, which would degrade gracefully. It crashes the overall user request and/or job that triggered. Which means whatever edit was being saved, or job queue action (RCFeed, Watchlist, Echo, template update, etc.) being performed ends up aborted or lost.

Having said that, it is no longer seen in the last 30 days. So I assume this particular case the slowless is just within our timeout budgets. These budgets were temporarily reduced by a bit around the time this task was filed but they've been restored since.