Maniphest T247670

PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Krinkle
	Mar 14 2020, 4:48 PM

Tags

Referenced Files

None

Subscribers

Description

These are making it hard for developers to find what the real issue is when they look at a build failure, especially if they're less experienced with PHPUnit or MW.

These warnings weren't there until a few weeks ago, which suggests it is either a recent regression due to a change in the test suite, or a pre-existing mistake that the recent PHPUnit upgrade started noticing and warning us about.

13) Wikibase\Client\Tests\ClientParserOutputDataUpdaterTest::testUpdateItemIdProperty
The optional $checkForObjectIdentity parameter of assertContains() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertContainsEquals() instead.

/workspace/src/maintenance/doMaintenance.php:99

Acceptance Criteria:

All tests in Wikibase\Client\Tests\ClientParserOutputDataUpdaterTest pass and do not generate PHPUnit warnings

Event Timeline

Krinkle created this task.Mar 14 2020, 4:48 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptMar 14 2020, 4:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It doesn't seem a recent regression, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+blame/de5e309c258b121bf0626728d8d9a6fd2ab0c717/client/tests/phpunit/includes/ClientParserOutputDataUpdaterTest.php#170

The fix should be as easy as doing what PHPUnit suggest.

Addshore triaged this task as Low priority.Apr 30 2020, 8:15 AM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

WMDE-leszek updated the task description. (Show Details)Oct 28 2020, 8:24 AM

WMDE-leszek set the point value for this task to 3.Oct 28 2020, 1:04 PM

WMDE-leszek moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Rosalie_WMDE claimed this task.Oct 28 2020, 5:06 PM

Rosalie_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

All the test in Wikibase\Client\Tests\ClientParserOutputDataUpdaterTest pass and do not generate PHPUnit warnings on my instance.

The fix => Change-Id: Id1d30691a1a0793fabfb07b2ae59ec96c9465131

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 4 2020, 9:28 AM

noarave closed this task as Resolved.Nov 4 2020, 10:27 AM

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

noarave moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/581630

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 10 2020, 1:15 PM