Page MenuHomePhabricator

Syntax highlighter in Firefox disorders the Proofread page sections with either webpage or Preview mode of refresh
Closed, DuplicatePublic

Description

  1. This affects ProofreadPage over/under edit view. - Side by side editing is not affected.
  2. This may require refreshing the webpage twice.
  3. The main text area moved to the top portion of the frame, the header section is placed below and is resting on top of the footer.
  4. This disordered display is retained in new browser sessions.

First tested on Firefox 74.0, on Windows 10, while logged in to Wikisource

In Wikisource

  • Removed vector.js code
  • Disabled vector.css
  • Disabled over/under in Preferences\Edit tab (reverted to default)
  • Disabled all gadgets with the following exceptions.
    • Retained General utilities needed by the templates and portals of this wiki project.
    • Retained Suppress display of the fundraiser banner.
    • Retained Adds a "*" tab or a "Purge" option within the actions-tab, which purges the page's cache when followed.
    • Retained Google OCR.

In Firefox

  • Deleted browser history.
  • Logged out and deleted all Wiki and Wikimedia related cookies.
  • Closed and reopened the browser.
  • Selected page https://en.wikisource.org/wiki/Page:Vol_6_History_of_Mexico_by_H_H_Bancroft.djvu/98 to be used for syntax highlighter display.
  • Logged in.
  • Selected Edit with the default source editor.
  • The toolbar is the standard source editor toolbar.
  • Reselected the above/under display on 'Proofread tools' segment of the toolbar (overrides the default).
  • Checked if the web page is correctly displayed before activating the Syntax highlighter.
    • the positions of the header, the main edit window, and the footer are displayed correctly.
  • Activated the Syntax highlighter.
  • Refreshed the browser page and also used 'Show Preview of the Proofread page' (sometimes 2 times)
  • Looked if there were any changes to the Proofreadpage edit layout.
  • The main text area moved to the top, the header box is resting on top of the footer box.

image.png (864×1 px, 782 KB)

This issue in Firefox revealed other issues but each should be posted separately.

Event Timeline

After experimenting, the font size returns to the user defined size when the page is refreshed, but this process must be repeated for every page.

This is the same in Firefox and Vivaldi browsers.

  1. My personal vector.css is empty.
  2. I go to https://en.wikisource.org/w/index.php?title=Page:Symonds_-_A_Problem_in_Modern_Ethics.djvu/15&action=edit&debug=true
  3. https://phabricator.wikimedia.org/diffusion/MW/browse/master/resources/src/mediawiki.editfont.less defines font-size: 13px; for .mw-editfont-monospace.
  4. I click "Syntax Highlighting" button in the tool bar
  5. In the source code of your browser's developer tools, you see that <textarea id="wpTextbox1"> gets style="display: none", hence not displayed.
  6. The CSS for .CodeMirror pre defines font-size: inherit;

In future bug reports, please provide a list of clear and exact steps to reproduce. See https://www.mediawiki.org/wiki/How_to_report_a_bug

@Aklapper, thanks for the reply and the info.

I have all the information on the steps to take to replicate the problem, but there are at least one other problem discovered while using the same steps. I would like to create a new bug report for one issue and have this bug report re-titled or annulled please.

@Ineuw: You are free to re-title or decline your tasks by clicking Edit Task. That does not require someone else.

Ineuw renamed this task from Syntax highlighter in edit mode reduces the font to minimum visibility in Wikisource to Syntax highlighter in Firefox disorders the Proofread page sections whith either webpage or Preview mode of refresh.Apr 13 2020, 10:43 PM
Ineuw renamed this task from Syntax highlighter in Firefox disorders the Proofread page sections whith either webpage or Preview mode of refresh to Syntax highlighter in Firefox disorders the Proofread page sections with either webpage or Preview mode of refresh.
Ineuw updated the task description. (Show Details)

There are other issues following the above steps, but it's possible that if this is corrected, the other issues may be corrected.

Inserted image in description, of the page layout with the issue.

This task lacked a list of complete steps that allow someone else to reproduce the problem.
In the future, please follow https://www.mediawiki.org/wiki/How_to_report_a_bug when reporting issues.

I can reproduce in Firefox 75 by:

Expected outcome: Main section displayed between "Header" section and "Footer" section.

Actual outcome: "Header" section displayed between main section and "Footer" section.

@Aklapper Please clarify what is missing in the description? I know that it happens in FF 75.0 which I am using now, but I started the problem data collection when FF was version 74.

@Aklapper Please clarify what is missing in the description?

Enabling "Horizontal layout when editing in the Page: namespace" on https://en.wikisource.org/wiki/Special:Preferences#mw-prefsection-editing :)

@Aklapper "Enabling "Horizontal layout when editing in the Page: namespace" on https://en.wikisource.org/wiki/Special:Preferences#mw-prefsection-editing :)"

Decided not to leave it in horizontal view because the default is side by side. But, it is changeable on a page by page basis in edit mode, on the Proofread Tools section of the toolbar.