1.35.0-wmf.28 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor: • LarsWirzenius
Release Version: 1.35.0-wmf.28
Release Date: Apr 13 2020, 12:00 AM

2020 week 16 1.35-wmf.28 Changes wmf/1.35.0-wmf.28

This MediaWiki Train Deployment is scheduled for the week of Monday, April 13th:

Monday April 13th	Tuesday, April 14th	Wednesday, April 15th	Thursday, April 16th	Friday
Backports only.	Branch `wmf.28` and deploy to Group 0 Wikis.	Deploy `wmf.28` to Group 1 Wikis.	Deploy `wmf.28` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.28 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.27

Next: 1.35.0-wmf.29

	Project	Branch	Lines +/-	Subject
	mediawiki/core	wmf/1.35.0-wmf.28	+966 -3	Include wmf/1.35.0-wmf.28 submodules and Defines.php

Customize query in gerrit

Related Objects

Mentioned Here: T248727: Replace ArticleRevisionUndeleted with RevisionUndeleted
rMWded5b87df12c: Merge "Add Special:MyLanguage for better user experience"

Event Timeline

thcipriani created this task.Mar 16 2020, 4:48 PM

Restricted Application added subscribers: • Mholloway, Aklapper. · View Herald TranscriptMar 16 2020, 4:48 PM

thcipriani assigned this task to Jdforrester-WMF.Mar 16 2020, 4:52 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: • LarsWirzenius.

thcipriani added a project: Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)) board.

RhinosF1 added a subscriber: RhinosF1.Mar 24 2020, 3:06 PM

thcipriani renamed this task from 1.36.0-wmf.1 deployment blockers to 1.35.0-wmf.28 deployment blockers.Mar 27 2020, 4:16 PM

thcipriani changed Release Version from 1.36.0-wmf.1 to 1.35.0-wmf.28.

Risky patch rolling this train: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/585376

Idea of the patch: replacing deprecated Revision with RevisionRecord.
Why risky: there's nothing particularly risky about this one, but it's big and touching a lot of code. FlaggedRevs is not well covered by tests and has a ton of edge cases
Testing: FlaggedRevs are enabled on test2wiki. Mostly manual testing unfortunately and log watching.
In case of UBN: revert
Contact: @Pchelolo or @DannyS712

• LarsWirzenius added a subscriber: • LarsWirzenius.Apr 14 2020, 11:15 AM

Mentioned in SAL (#wikimedia-operations) [2020-04-14T15:49:06Z] <James_F> 1.35.0-wmf.28 was branched at ded5b87df12cea88d94dde0fa22cac13227f8e92 for T247775

Change 588726 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@wmf/1.35.0-wmf.28] Include wmf/1.35.0-wmf.28 submodules and Defines.php

https://gerrit.wikimedia.org/r/588726

gerritbot added a project: Patch-For-Review.Apr 14 2020, 3:55 PM

Change 588726 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.28] Include wmf/1.35.0-wmf.28 submodules and Defines.php

https://gerrit.wikimedia.org/r/588726

Mentioned in SAL (#wikimedia-operations) [2020-04-14T16:20:36Z] <James_F> Scap cleaning 1.35.0-wmf.25 T247775

Mentioned in SAL (#wikimedia-operations) [2020-04-14T16:52:22Z] <jforrester@deploy1001> Started scap: Testwikis to php-1.35.0-wmf.28 and rebuild i18n cache for T247775

Mentioned in SAL (#wikimedia-operations) [2020-04-14T17:34:59Z] <jforrester@deploy1001> Finished scap: Testwikis to php-1.35.0-wmf.28 and rebuild i18n cache for T247775 (duration: 42m 37s)

So in T248727: Replace ArticleRevisionUndeleted with RevisionUndeleted I missed up with my understanding of one of the hook parameters that was provided, and did not provide it in the replacement. This has since been fixed, but was only noticed after the branch was cut. If it causes any issues, the core and extension (Flow and LiquidThreads) commits were cherry picked and are available to merge:

Core - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/588815/ (has a more detailed explanation of the issue as well)
LiquidThreads - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/LiquidThreads/+/588816/
Flow - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/588817/

These were all already merged to the master version

Thanks. @Pchelolo, do you think it's worth back-porting now just in case?

In T247775#6057450, @Jdforrester-WMF wrote:

Thanks. @Pchelolo, do you think it's worth back-porting now just in case?

Honestly, I have absolutely no idea if that will cause any trouble or not. It's related to page undeletions and page ids and it seems tricky. If it's not a big burden - maybe it worths it, to be on the safe side.

In T247775#6057467, @Pchelolo wrote:

In T247775#6057450, @Jdforrester-WMF wrote:

Thanks. @Pchelolo, do you think it's worth back-porting now just in case?

Honestly, I have absolutely no idea if that will cause any trouble or not. It's related to page undeletions and page ids and it seems tricky. If it's not a big burden - maybe it worths it, to be on the safe side.

WFM.

In T247775#6057631, @Jdforrester-WMF wrote:

In T247775#6057467, @Pchelolo wrote:

In T247775#6057450, @Jdforrester-WMF wrote:

Thanks. @Pchelolo, do you think it's worth back-porting now just in case?

Honestly, I have absolutely no idea if that will cause any trouble or not. It's related to page undeletions and page ids and it seems tricky. If it's not a big burden - maybe it worths it, to be on the safe side.

WFM.

… and deployed.

In T247775#6044738, @Pchelolo wrote:

Risky patch rolling this train: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/585376

Idea of the patch: replacing deprecated Revision with RevisionRecord.
Why risky: there's nothing particularly risky about this one, but it's big and touching a lot of code. FlaggedRevs is not well covered by tests and has a ton of edge cases
Testing: FlaggedRevs are enabled on test2wiki. Mostly manual testing unfortunately and log watching.
In case of UBN: revert
Contact: @Pchelolo or @DannyS712

Superficially, FR seems to be working as expected in group1 wikis that I looked at. 🤞🏽.

Train has fully deployed.

1.35.0-wmf.28 deployment blockersClosed, ResolvedPublicReleaseActions