From @Krinkle in https://phabricator.wikimedia.org/T232140#5970936:
@Jdlrobson There are still two unresolved issues:
My understanding would be that we would continue to support wgLogo given the disruption to 3rd parties. In my head wgLogos was more of a generic replacement for wgLogoHD which was deprecated.
I can however see the simplicity of supporting just wgLogos here. If we did want to take that approach I would like to leave more time for wgLogo references to be updated to target the ResourceLoaderSkin getAvailableLogos method first.
I agree we should continue to support wgLogo, possibly indefinitely. We have a number of simple oneline mapping in Setup.php like that, which is no trouble at all.
However, we should have the default output from the installer, and the default fallback image, utilize the new wgLogos structure.
Change 575293 had a related patch set uploaded (by Krinkle; owner: Jforrester):
[mediawiki/core@master] installer: Write to wgLogos, not wgLogo
I've given an initial review, some fixes and pointers for the rest. Let me know if/when you need a re-review.
Bumping to high given the new release for 1.35 was announced on wikitech-l today for July and this needs to be done by then. cc @ovasileva
Go for it. Note there is an existing patch https://gerrit.wikimedia.org/r/c/575293 with reviews that you can draw inspiration from. (^ FYI @Jdforrester-WMF )
Change 610354 had a related patch set uploaded (by TabShaikh; owner: TabShaikh):
[mediawiki/core@master] wglogos used for installer
Change 612437 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Add support in installer for other logo keys
Seems that logo work also caused the regression in T254229: Sister project logos not showing in landing pages for non-existant projects on Incubator.
Change 610354 abandoned by Krinkle:
[mediawiki/core@master] Installer: Use wgLogos instead of wgLogo
Reason:
Squashed into https://gerrit.wikimedia.org/r/c/mediawiki/core/ /575293
Change 575293 merged by jenkins-bot:
[mediawiki/core@master] installer: Write to wgLogos, not wgLogo
Change 616982 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_35] installer: Write to wgLogos, not wgLogo
Change 616982 merged by jenkins-bot:
[mediawiki/core@REL1_35] installer: Write to wgLogos, not wgLogo
Change 612437 abandoned by Jdlrobson:
[mediawiki/core@master] Add support in installer for other logo keys
Reason:
Not a priority of mine right now (I may resurrect this patch nearer to the 1.36 release). Somebody should feel free to fork this in the mean time if they feel inspired!