Page MenuHomePhabricator
Create Task
Maniphest T247801

Remove support for calling (Archived|OldLocal)File::userCan without passing a user
Closed, ResolvedPublic
Actions

Description

All callers updated, deprecated in 1.35

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Revert "Remove support for (Archived|OldLocal)File::userCan without a user""mediawiki/coremaster+9 -20
Remove support for (Archived|OldLocal)File::userCan without a usermediawiki/coremaster+9 -17
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 created this task.Mar 17 2020, 12:20 AM
DannyS712 changed the task status from Open to Stalled.
DannyS712 triaged this task as Medium priority.
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

Cannot be actioned until 1.36

DannyS712 moved this task from Next to Later on the User-DannyS712 board.Apr 13 2020, 9:13 PM
DannyS712 changed the task status from Stalled to Open.Jul 14 2020, 9:51 AM
gerritbot added a comment.Sep 10 2020, 1:09 AM

Change 626251 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove support for (Archived|OldLocal)File::userCan without a user

https://gerrit.wikimedia.org/r/626251

gerritbot added a project: Patch-For-Review.Sep 10 2020, 1:09 AM
DannyS712 moved this task from Later to Awaiting review and deployment on the User-DannyS712 board.Sep 10 2020, 1:13 AM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).
gerritbot added a comment.Sep 10 2020, 4:05 PM

Change 626251 merged by jenkins-bot:
[mediawiki/core@master] Remove support for (Archived|OldLocal)File::userCan without a user

https://gerrit.wikimedia.org/r/626251

Jdforrester-WMF closed this task as Resolved.Sep 10 2020, 4:05 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 10 2020, 4:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 10 2020, 5:00 PM
DannyS712 reopened this task as Open.Sep 16 2020, 3:04 PM
DannyS712 added a subtask: T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275.
DannyS712 closed subtask T263014: Argument 2 passed to File::userCan() must be an instance of User, null given, called in /srv/mediawiki/php-1.36.0-wmf.9/includes/filerepo/LocalRepo.php on line 275 as Resolved.Sep 20 2020, 8:48 PM
gerritbot added a comment.Sep 20 2020, 8:49 PM

Change 628561 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Revert "Revert "Remove support for (Archived|OldLocal)File::userCan without a user""

https://gerrit.wikimedia.org/r/628561

gerritbot added a project: Patch-For-Review.Sep 20 2020, 8:49 PM
gerritbot added a comment.Sep 29 2020, 4:43 PM

Change 628561 merged by jenkins-bot:
[mediawiki/core@master] Revert "Revert "Remove support for (Archived|OldLocal)File::userCan without a user""

https://gerrit.wikimedia.org/r/628561

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED); removed MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 29 2020, 5:00 PM
DannyS712 closed this task as Resolved.Sep 29 2020, 5:00 PM
DannyS712 removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits