Page MenuHomePhabricator

jakub-onderka/php-parallel-lint has been abandoned, use php-parallel-lint/php-parallel-lint instead
Closed, ResolvedPublic

Description

Per composer, MediaWiki core uses jakub-onderka/php-parallel-lint (https://packagist.org/packages/jakub-onderka/php-parallel-lint) package which has been abandoned and no longer maintained, use php-parallel-lint/php-parallel-lint (https://packagist.org/packages/php-parallel-lint/php-parallel-lint) package instead.

Package jakub-onderka/php-parallel-lint is abandoned, you should avoid using it. Use php-parallel-lint/php-parallel-lint instead.

Should we possibly update MediaWiki vendor and migrate the requirement in composer.json in core?

Event Timeline

And in other places too, no just in core. :)

Change 581664 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[labs/libraryupgrader@master] Replace jakub-onderka/php-parallel-lint with php-parallel-lint/php-parallel-lint

https://gerrit.wikimedia.org/r/581664

So I spent a fair bit of time re-writing the whole library to have the concept of replacements, but then scaled it massively back as it seemed overkill. Legoktm will likely have thoughts. :-)

Anyone know if jakub-onderka/php-console-highlighter also gets renamed?

php-parallel-lint also have a new version v1.1.0, which should be set in the same patch set when upgrading.

Anyone know if jakub-onderka/php-console-highlighter also gets renamed?

php-parallel-lint also have a new version v1.1.0, which should be set in the same patch set when upgrading.

Looks like it should be

https://github.com/JakubOnderka/PHP-Console-Highlighter/pull/21 suggests the repo and https://packagist.org/packages/jakub-onderka/php-console-highlighter just haven't been updated/marked correctly yet

Oh, I was confused why I get this:

kizule@kizule-laptop1:~/Desktop/development/MintyDocs$ composer install && composer test
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 13 installs, 0 updates, 0 removals
  - Installing jakub-onderka/php-parallel-lint (v1.0.0): Loading from cache
  - Installing jakub-onderka/php-console-color (v0.2): Loading from cache
  - Installing jakub-onderka/php-console-highlighter (v0.4): Loading from cache
  - Installing squizlabs/php_codesniffer (3.5.3): Loading from cache
  - Installing composer/spdx-licenses (1.5.2): Loading from cache
  - Installing composer/semver (1.5.1): Loading from cache
  - Installing mediawiki/mediawiki-codesniffer (v30.0.0): Loading from cache
  - Installing psr/container (1.0.0): Loading from cache
  - Installing symfony/service-contracts (v2.0.1): Loading from cache
  - Installing symfony/polyfill-php73 (v1.15.0): Loading from cache
  - Installing symfony/polyfill-mbstring (v1.15.0): Loading from cache
  - Installing symfony/console (v5.0.7): Loading from cache
  - Installing mediawiki/minus-x (1.0.0): Loading from cache
symfony/service-contracts suggests installing symfony/service-implementation
symfony/console suggests installing symfony/event-dispatcher
symfony/console suggests installing symfony/lock
symfony/console suggests installing symfony/process
symfony/console suggests installing psr/log (For using the console logger)
Package jakub-onderka/php-parallel-lint is abandoned, you should avoid using it. Use php-parallel-lint/php-parallel-lint instead.
Package jakub-onderka/php-console-color is abandoned, you should avoid using it. Use php-parallel-lint/php-console-color instead.
Package jakub-onderka/php-console-highlighter is abandoned, you should avoid using it. Use php-parallel-lint/php-console-highlighter instead.
Writing lock file
Generating autoload files

But I see now reasons. Can we fix these warnings?

Aa per Lego’s comment, we’re waiting for some new releases to be tagged so we don’t have to fo this twice

Aa per Lego’s comment, we’re waiting for some new releases to be tagged so we don’t have to fo this twice

Cool, thanks for information!

Reedy changed the task status from Open to Stalled.EditedApr 26 2020, 5:47 PM
Reedy added a project: Upstream.

https://packagist.org/packages/php-parallel-lint/php-console-highlighter

v0.4

Requires

    php: >=5.4.0
    ext-tokenizer: *
    jakub-onderka/php-console-color: ~0.2

Still waiting on https://github.com/php-parallel-lint/PHP-Console-Highlighter/issues/1

Change 581664 merged by jenkins-bot:
[labs/libraryupgrader@master] Replace jakub-onderka/* with php-parallel-lint/*

https://gerrit.wikimedia.org/r/581664

It seems there is no bump of the version for parellel-lint needed for the php7.4 support

It seems there is no bump of the version for parellel-lint needed for the php7.4 support

Now this has landed, I'll add it to the config as a target version.

Change 599910 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[labs/libraryupgrader/config@master] Bump php-parallel-lint/* over to new root names and latest versions

https://gerrit.wikimedia.org/r/599910

Change 599910 merged by jenkins-bot:
[labs/libraryupgrader/config@master] Bump php-parallel-lint/* over to new root names and latest versions

https://gerrit.wikimedia.org/r/599910

Jdforrester-WMF claimed this task.

OK, this should now be fixing itself as LibUp upgrades everyone. Calling this Resolve for now, but I'll keep an eye on the upgrades.

OK, this should now be fixing itself as LibUp upgrades everyone. Calling this Resolve for now, but I'll keep an eye on the upgrades.

Thanks for the bump, but I would assume the current libup run (to update codesniffer) runs to end before that is picked up