Page MenuHomePhabricator

mobile-html - Erase saved articles in Settings size is off
Closed, DeclinedPublicBUG REPORT

Description

How many times were you able to reproduce it?

Every time

Steps to reproduce

  1. Save many articles, wait for them all to cache
  2. Go to Settings > Erase Saved Articles. Note the text "Erasing your saved articles will free up about X MB of space)". Tap erase.

Expected results

This label should decrement a significant amount.

Actual results

It only decrements a little each time (Ex. ~420MB went down to ~410MB). We need to investigate and be sure all related files (content and header files for images, shared resources, and mobile-html) are deleted.

Screenshots

Environments observed

App version: 6.6.0
OS versions: 13.3.1
Device model: iPhone 7
Device language: EN

Event Timeline

Update - for a while it was slowly decreasing each time I returned to the screen because SavedArticlesFetcher was deleting them one at a time. But now it seems to be stuck at 436.8MB with no articles showing in the Saved tab.

Pulled this into 6.6 because it seems like a quick fix, but we think it did exist before mobile-html rewrite.

@Tsevener & @JMinor - Sorry for the delay on this one. I am having some trouble with this one. For example, today I went into Article Storage and Sync and the erase text said 754.5 MB of space. After hitting erase it said 740.5 MB. After hitting erase again it said 724.5 MB. After hitting it again, it said 270.5 MB. It is hard to tell if this is expected. Based on the language of the text, should it go to zero or close to it?

I believe we're looking for a low number, but not necessarily 0. I'm guessing there may be a timing issue, where items are being slowly deleted so each time you press it, its going down, but its not a clear experince. Could be a bug too, but this may be a matter of needing a more gradual indication of the deletion process or some messaging when pressing the button if a deletion is in progress.

Moving to 6.7 for acceptance clarification.

@ABorbaWMF @JMinor yep, it is slowly deleting all your articles (one at a time) and reflecting the size each time you revisit the screen. So without tapping the button again, if you leave the screen then come back, the number will be lower each time. The bug before was that upon backgrounding then foregrounding, the references to the articles that needed to be deleted were lost, so the process became stuck and you never saw the size decrement after that point. Now it should at least always pick back up and continue deleting and decreasing.

But I agree that we probably ought to rethink the user experience and show that it is a gradual process. This slow decreasing confused me too when I first saw it.

LGoto subscribed.

This task was closed as part of the iOS team backlog grooming.