Page MenuHomePhabricator

Audit all ->doDeleteArticleReal calls
Closed, ResolvedPublic

Description

For WikiPage: signature needs to be changes
For Article: Needs to be wikipage

Event Timeline

DannyS712 triaged this task as Medium priority.Mar 17 2020, 4:36 PM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

https://codesearch.wmflabs.org/search/?q=-%3EdoDeleteArticleReal%5C(&i=nope&files=&repos=

  • Core
    • FileDeleteForm: WikiPage
    • MovePage: WikiPage
    • ApiDelete: Page (will be clarified as part of T239975)
    • Article: Direct calls to WikiPage methods
    • WikiPage: WikiPage
    • SpecialMovePage: WikiPage
    • EditPageTest: WikiPage (all)
    • TemplateCategoriesTest: WikiPage
    • ApiQueryRecentChangesIntegrationTest: WikiPage
    • ApiQueryWatchlistIntegrationTest: WikiPage
    • PageArchiveTestBase: WikiPage
    • WikiPageDbTestBase: WikiPage (all)

Translate:

  • SpecialManageTranslatorSandbox: WikiPage
  • TranslateDeleteJob: WikiPage

@Nikerabbit heads up that Nikerabbit / mediawiki-extensions-Termbank has 2 calls to WikiPage::doDeleteArticleReal that will need to be updated to pass a user

AbuseFilter: AbuseFilterConsequencesTest - WikiPage
BlueSpiceSocialProfile: Handler - WikiPage
CirrusSearch: deleteBrowserTestPages - WikiPage
CommentStreams: Comment - WikiPage
Flow: FlowRestoreLQT - WikiPage
GlobalCssJs: removeOldManualUserPages - WikiPage
Jade: CleanJudgmentLinksTest - WikiPage
MassMessage: MassMessageJobTest - WikiPage
SplitPrivateWiki: SyncArticleJob - WikiPage
Thanks: ApiCoreThankIntegrationTest - WikiPage x2
WebDAV: WebDAVPageFile - WikiPage