Page MenuHomePhabricator
Create Task
Maniphest T247944

Show opt-out user preference counts on the Grafana board
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Add the stats tracked in T246104: Track opt-out user preference for new conflict UI to Grafana.

https://grafana.wikimedia.org/d/000000346/mediawiki-twocolconflict

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Only track unique users disabling TwoColConflictanalytics/wmde/scriptsmaster+8 -9
Fix unique user count for TwoColConfanalytics/wmde/scriptsproduction+1 -0
Fix unique user count for TwoColConfanalytics/wmde/scriptsmaster+1 -0
Only track unique users disabling TwoColConflictanalytics/wmde/scriptsproduction+8 -9
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Mar 18 2020, 10:49 AM
WMDE-Fisch set the point value for this task to 2.
Lena_WMDE moved this task from Backlog to Watching on the Two-Column-Edit-Conflict-Merge board.Mar 18 2020, 11:06 AM
Lena_WMDE moved this task from Watching to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.
WMDE-Fisch mentioned this in T246104: Track opt-out user preference for new conflict UI.Mar 19 2020, 11:04 AM
Andrew-WMDE claimed this task.Mar 20 2020, 9:09 AM
Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-03-18 board.
Andrew-WMDE added a comment.Mar 20 2020, 12:07 PM

Proposed graph:
https://grafana.wikimedia.org/d/000000346/mediawiki-twocolconflict?orgId=1&refresh=1d&from=now-7d&to=now&fullscreen&panelId=48

Andrew-WMDE changed the task status from Open to Stalled.Mar 20 2020, 12:08 PM

Waiting for data points

WMDE-Fisch changed the task status from Stalled to Open.Mar 31 2020, 7:16 AM
WMDE-Fisch moved this task from Doing to Demo on the WMDE-QWERTY-Sprint-2020-03-18 board.

Data comes in waiting for demo, see https://grafana.wikimedia.org/d/000000346/mediawiki-twocolconflict?orgId=1&refresh=1d&from=now-7d&to=now&fullscreen&panelId=48

Lena_WMDE subscribed.Mar 31 2020, 11:37 AM

To do: check wether this is showing duplicates of users opting out in different wikis.

WMDE-Fisch added a comment.Mar 31 2020, 12:06 PM
In T247944#6014347, @Lena_WMDE wrote:

To do: check wether this is showing duplicates of users opting out in different wikis.

Yes, the current implementation of this is showing duplicates of users when they opt-out on different wikis. I'm not sure how easy this can be resolved.

WMDE-Fisch moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-03-18 board.Apr 1 2020, 10:23 AM
Lena_WMDE added a project: WMDE-QWERTY-Sprint-2020-04-01.Apr 1 2020, 10:42 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-04-01 board.Apr 7 2020, 10:56 AM
gerritbot added a comment.Apr 7 2020, 11:14 AM

Change 587232 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[analytics/wmde/scripts@master] Only track unique users disabling TwoColConflict

https://gerrit.wikimedia.org/r/587232

gerritbot added a project: Patch-For-Review.Apr 7 2020, 11:14 AM
gerritbot added a comment.Apr 7 2020, 6:38 PM

Change 587232 merged by jenkins-bot:
[analytics/wmde/scripts@master] Only track unique users disabling TwoColConflict

https://gerrit.wikimedia.org/r/587232

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2020, 7:10 PM
gerritbot added a comment.Apr 8 2020, 9:18 AM

Change 587496 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[analytics/wmde/scripts@production] Only track unique users disabling TwoColConflict

https://gerrit.wikimedia.org/r/587496

gerritbot added a project: Patch-For-Review.Apr 8 2020, 9:18 AM
WMDE-Fisch added a comment.Apr 8 2020, 9:21 AM

Just for the record: We decided on just counting the unique users with the setting disabled.

gerritbot added a comment.Apr 8 2020, 9:22 AM

Change 587496 merged by jenkins-bot:
[analytics/wmde/scripts@production] Only track unique users disabling TwoColConflict

https://gerrit.wikimedia.org/r/587496

WMDE-Fisch moved this task from Doing to Demo on the WMDE-QWERTY-Sprint-2020-04-01 board.Apr 8 2020, 9:25 AM

Starting tomorrow the numbers should only reflect unique users that have the setting disabled.

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2020, 10:10 AM
gerritbot added a comment.Apr 9 2020, 11:45 AM

Change 587720 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[analytics/wmde/scripts@master] Fix unique user count for TwoColConf

https://gerrit.wikimedia.org/r/587720

gerritbot added a project: Patch-For-Review.Apr 9 2020, 11:45 AM
gerritbot added a comment.Apr 9 2020, 12:44 PM

Change 587720 merged by jenkins-bot:
[analytics/wmde/scripts@master] Fix unique user count for TwoColConf

https://gerrit.wikimedia.org/r/587720

gerritbot added a comment.Apr 9 2020, 12:49 PM

Change 587728 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[analytics/wmde/scripts@production] Fix unique user count for TwoColConf

https://gerrit.wikimedia.org/r/587728

gerritbot added a comment.Apr 9 2020, 12:51 PM

Change 587728 merged by jenkins-bot:
[analytics/wmde/scripts@production] Fix unique user count for TwoColConf

https://gerrit.wikimedia.org/r/587728

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 1:10 PM
WMDE-Fisch added a comment.Apr 14 2020, 8:45 AM

Opt-out counts are correctly tracking the unique users now. See the corresponding pane form the board[1].

The gap on the 9th was due to a bug in the first version of that patch. But now it's a good hint when the unique counts started. On both sides of the gap the number is the same so I guess it's likely that the numbers before were unique as well by accident.

[1] https://grafana.wikimedia.org/d/000000346/mediawiki-twocolconflict?panelId=48&fullscreen&orgId=1

thiemowmde closed this task as Resolved.Apr 14 2020, 12:01 PM
thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-04-01 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits